Add GRPCMessageDeframer
#1776
Merged
Add GRPCMessageDeframer
#1776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
requested changes
Jan 25, 2024
glbrntt
reviewed
Jan 26, 2024
glbrntt
requested changes
Jan 26, 2024
Collaborator
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
This looks great but we need one more test please!
glbrntt
approved these changes
Jan 26, 2024
Collaborator
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
This looks great, thanks Gus!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need a helper to deframe gRPC messages for the HTTP2 transport implementation we're carrying out.
This is the counterpart to #1768
Modifications
Added a
GRPCMessageDeframer. This implementation conforms to NIO'sNIOSingleStepByteToMessageDecoderto reuse the logic of stitching together multiple frames.Result
We've got a usable gRPC deframer now.