Make testHedgingWhenAllAttemptsResultInNonFatalCodes more reliable #1780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `testHedgingWhenAllAttemptsResultInNonFatalCodes` fails occasionally. The reason for this is that when the event stating that next scheduled attempt is cancelled is consumed it cancels the next scheduled attempt again. However, this is incorrect, another hedged result may have re-scheduled an attempt which is subsequently cancelled by accident. Modifications: Don't double cancel the next scheduled attempt. result: The test passes more reliably
gjcairo
approved these changes
Jan 29, 2024
glbrntt
added a commit
to glbrntt/grpc-swift
that referenced
this pull request
Feb 5, 2024
…rpc#1780) Motivation: `testHedgingWhenAllAttemptsResultInNonFatalCodes` fails occasionally. The reason for this is that when the event stating that next scheduled attempt is cancelled is consumed it cancels the next scheduled attempt again. However, this is incorrect, another hedged result may have re-scheduled an attempt which is subsequently cancelled by accident. Modifications: Don't double cancel the next scheduled attempt. result: The test passes more reliably
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
testHedgingWhenAllAttemptsResultInNonFatalCodesfails occasionally. The reason for this is that when the event stating that next scheduled attempt is cancelled is consumed it cancels the next scheduled attempt again. However, this is incorrect, another hedged result may have re-scheduled an attempt which is subsequently cancelled by accident.Modifications:
Don't double cancel the next scheduled attempt.
result:
The test passes more reliably