[CodeGenLib] Add avialability gurads in generated code #1791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The protocols from GRPCCore that structs and protocols from the generated code conform to can be used only for some OSes, so we need to add the same availability guards in the generated code. Modifications: - created the AvailabilityDescription struct in StructuredSwiftRepresentation - created the declaraion for a guarded declaration - created the rendering functions for guarded declarations and the availability guard - added the guarded declaration in the translators where needed - changed the tests accordingly Result: The generated code will contain the necessary availability guards.
glbrntt
requested changes
Feb 6, 2024
Collaborator
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
This looks good but needs a test for the text based renderer
Comment on lines
+1080
to
+1083
| func renderGuardedDeclaration(availability: AvailabilityDescription, declaration: Declaration) { | ||
| renderAvailability(availability) | ||
| renderDeclaration(declaration) | ||
| } |
Collaborator
There was a problem hiding this comment.
Can you add a test to the TextBasedRendererTests for this?
glbrntt
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The protocols from GRPCCore that structs and protocols from the generated code conform to can be used only for some OSes, so we need to add the same availability guards in the generated code.
Modifications:
Result:
The generated code will contain the necessary availability guards.