-
Notifications
You must be signed in to change notification settings - Fork 435
Add target and generated code for QPS #1827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d8470a1
Add target and generated code for QPS
stefanadranca b3f1483
added main to executable target
stefanadranca 642c894
fixed formatting
stefanadranca e4841b0
added missing generated code files
stefanadranca 7b7af66
changed naming style for generated code files
stefanadranca 0028c8d
generate only the service code for the worker service
stefanadranca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| // Copyright 2017 gRPC authors. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| syntax = "proto3"; | ||
|
|
||
| package grpc.core; | ||
|
|
||
| message Bucket { | ||
| double start = 1; | ||
| uint64 count = 2; | ||
| } | ||
|
|
||
| message Histogram { | ||
| repeated Bucket buckets = 1; | ||
| } | ||
|
|
||
| message Metric { | ||
| string name = 1; | ||
| oneof value { | ||
| uint64 count = 10; | ||
| Histogram histogram = 11; | ||
| } | ||
| } | ||
|
|
||
| message Stats { | ||
| repeated Metric metrics = 1; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| // Copyright 2015 gRPC authors. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // An integration test service that covers all the method signature permutations | ||
| // of unary/streaming requests/responses. | ||
| syntax = "proto3"; | ||
|
|
||
| import "grpc/testing/messages.proto"; | ||
|
|
||
| package grpc.testing; | ||
|
|
||
| option java_multiple_files = true; | ||
| option java_package = "io.grpc.testing"; | ||
| option java_outer_classname = "BenchmarkServiceProto"; | ||
|
|
||
| service BenchmarkService { | ||
| // One request followed by one response. | ||
| // The server returns the client payload as-is. | ||
| rpc UnaryCall(SimpleRequest) returns (SimpleResponse); | ||
|
|
||
| // Repeated sequence of one request followed by one response. | ||
| // Should be called streaming ping-pong | ||
| // The server returns the client payload as-is on each response | ||
| rpc StreamingCall(stream SimpleRequest) returns (stream SimpleResponse); | ||
|
|
||
| // Single-sided unbounded streaming from client to server | ||
| // The server returns the client payload as-is once the client does WritesDone | ||
| rpc StreamingFromClient(stream SimpleRequest) returns (SimpleResponse); | ||
|
|
||
| // Single-sided unbounded streaming from server to client | ||
| // The server repeatedly returns the client payload as-is | ||
| rpc StreamingFromServer(SimpleRequest) returns (stream SimpleResponse); | ||
|
|
||
| // Two-sided unbounded streaming between server to client | ||
| // Both sides send the content of their own choice to the other | ||
| rpc StreamingBothWays(stream SimpleRequest) returns (stream SimpleResponse); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we use
"FileNaming=PathToUnderscores"but below we use"FileNaming=DropPath"– why?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 2 stat.proto file - one in grpc/core and one in grpc/testing. As all the other .proto files are located within 'grpc/testing' I was thinking we can drop the path from their names, and keep the path only for the 'stats.proto' file from the other module, to differentiate the 2 files containing generated code for the 2 'stats.proto' files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I didn't realise there were two, thanks for explaining. In that case I'd rather we stick to one naming style if possible.