-
Notifications
You must be signed in to change notification settings - Fork 435
Add GRPCServerStreamHandler #1832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0abcab0
Add GRPCServerStreamHandler
gjcairo 8fe0f35
Add tests
gjcairo 7a03446
PR changes
gjcairo 9fd0e04
Fix flushing logic
gjcairo 81fd813
Formatting
gjcairo 18784ee
Replace channel close with user inbound inputClosed event fired
gjcairo 0ec7e3c
PR changes
gjcairo d8d5633
PR nits
gjcairo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
217 changes: 217 additions & 0 deletions
217
Sources/GRPCHTTP2Core/Server/GRPCServerStreamHandler.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,217 @@ | ||
| /* | ||
| * Copyright 2024, gRPC Authors All rights reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import GRPCCore | ||
| import NIOCore | ||
| import NIOHTTP2 | ||
|
|
||
| @available(macOS 13.0, iOS 16.0, watchOS 9.0, tvOS 16.0, *) | ||
| final class GRPCServerStreamHandler: ChannelDuplexHandler { | ||
| typealias InboundIn = HTTP2Frame.FramePayload | ||
| typealias InboundOut = RPCRequestPart | ||
|
|
||
| typealias OutboundIn = RPCResponsePart | ||
| typealias OutboundOut = HTTP2Frame.FramePayload | ||
|
|
||
| private var stateMachine: GRPCStreamStateMachine | ||
|
|
||
| private var isReading = false | ||
| private var flushPending = false | ||
|
|
||
| // We buffer the final status + trailers to avoid reordering issues (i.e., | ||
| // if there are messages still not written into the channel because flush has | ||
| // not been called, but the server sends back trailers). | ||
| private var pendingTrailers: HTTP2Frame.FramePayload? | ||
|
|
||
| init( | ||
| scheme: Scheme, | ||
| acceptedEncodings: [CompressionAlgorithm], | ||
| maximumPayloadSize: Int, | ||
| skipStateMachineAssertions: Bool = false | ||
| ) { | ||
| self.stateMachine = .init( | ||
| configuration: .server(.init(scheme: scheme, acceptedEncodings: acceptedEncodings)), | ||
| maximumPayloadSize: maximumPayloadSize, | ||
| skipAssertions: skipStateMachineAssertions | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| // - MARK: ChannelInboundHandler | ||
|
|
||
| @available(macOS 13.0, iOS 16.0, watchOS 9.0, tvOS 16.0, *) | ||
| extension GRPCServerStreamHandler { | ||
| func channelRead(context: ChannelHandlerContext, data: NIOAny) { | ||
| self.isReading = true | ||
| let frame = self.unwrapInboundIn(data) | ||
| switch frame { | ||
| case .data(let frameData): | ||
| let endStream = frameData.endStream | ||
| switch frameData.data { | ||
| case .byteBuffer(let buffer): | ||
| do { | ||
| try self.stateMachine.receive(message: buffer, endStream: endStream) | ||
gjcairo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| loop: while true { | ||
| switch self.stateMachine.nextInboundMessage() { | ||
| case .receiveMessage(let message): | ||
| context.fireChannelRead(self.wrapInboundOut(.message(message))) | ||
| case .awaitMoreMessages: | ||
| break loop | ||
| case .noMoreMessages: | ||
| context.fireUserInboundEventTriggered(ChannelEvent.inputClosed) | ||
| break loop | ||
| } | ||
| } | ||
| } catch { | ||
| context.fireErrorCaught(error) | ||
| } | ||
|
|
||
| case .fileRegion: | ||
| preconditionFailure("Unexpected IOData.fileRegion") | ||
| } | ||
|
|
||
| case .headers(let headers): | ||
| do { | ||
| let action = try self.stateMachine.receive( | ||
| metadata: headers.headers, | ||
gjcairo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| endStream: headers.endStream | ||
| ) | ||
| switch action { | ||
| case .receivedMetadata(let metadata): | ||
| context.fireChannelRead(self.wrapInboundOut(.metadata(metadata))) | ||
|
|
||
| case .rejectRPC(let trailers): | ||
| self.flushPending = true | ||
| let response = HTTP2Frame.FramePayload.headers(.init(headers: trailers, endStream: true)) | ||
| context.write(self.wrapOutboundOut(response), promise: nil) | ||
|
|
||
| case .receivedStatusAndMetadata: | ||
| throw RPCError( | ||
| code: .internalError, | ||
| message: "Server cannot get receivedStatusAndMetadata." | ||
| ) | ||
|
|
||
| case .doNothing: | ||
| throw RPCError(code: .internalError, message: "Server cannot receive doNothing.") | ||
| } | ||
| } catch { | ||
| context.fireErrorCaught(error) | ||
| } | ||
|
|
||
| case .ping, .goAway, .priority, .rstStream, .settings, .pushPromise, .windowUpdate, | ||
gjcairo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| .alternativeService, .origin: | ||
| () | ||
| } | ||
| } | ||
|
|
||
| func channelReadComplete(context: ChannelHandlerContext) { | ||
| self.isReading = false | ||
| if self.flushPending { | ||
| self.flushPending = false | ||
| context.flush() | ||
| } | ||
| context.fireChannelReadComplete() | ||
| } | ||
|
|
||
| func handlerRemoved(context: ChannelHandlerContext) { | ||
| self.stateMachine.tearDown() | ||
| } | ||
| } | ||
|
|
||
| // - MARK: ChannelOutboundHandler | ||
|
|
||
| @available(macOS 13.0, iOS 16.0, watchOS 9.0, tvOS 16.0, *) | ||
| extension GRPCServerStreamHandler { | ||
| func write(context: ChannelHandlerContext, data: NIOAny, promise: EventLoopPromise<Void>?) { | ||
| let frame = self.unwrapOutboundIn(data) | ||
| switch frame { | ||
| case .metadata(let metadata): | ||
| do { | ||
| self.flushPending = true | ||
| let headers = try self.stateMachine.send(metadata: metadata) | ||
| context.write(self.wrapOutboundOut(.headers(.init(headers: headers))), promise: nil) | ||
gjcairo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // TODO: move the promise handling into the state machine | ||
| promise?.succeed() | ||
| } catch { | ||
| context.fireErrorCaught(error) | ||
| // TODO: move the promise handling into the state machine | ||
| promise?.fail(error) | ||
| } | ||
|
|
||
| case .message(let message): | ||
| do { | ||
| try self.stateMachine.send(message: message, endStream: false) | ||
| // TODO: move the promise handling into the state machine | ||
| promise?.succeed() | ||
| } catch { | ||
| context.fireErrorCaught(error) | ||
gjcairo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // TODO: move the promise handling into the state machine | ||
| promise?.fail(error) | ||
| } | ||
|
|
||
| case .status(let status, let metadata): | ||
| do { | ||
| let headers = try self.stateMachine.send(status: status, metadata: metadata) | ||
| let response = HTTP2Frame.FramePayload.headers(.init(headers: headers, endStream: true)) | ||
| self.pendingTrailers = response | ||
| // TODO: move the promise handling into the state machine | ||
| promise?.succeed() | ||
| } catch { | ||
| context.fireErrorCaught(error) | ||
| // TODO: move the promise handling into the state machine | ||
| promise?.fail(error) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func flush(context: ChannelHandlerContext) { | ||
| if self.isReading { | ||
| // We don't want to flush yet if we're still in a read loop. | ||
| return | ||
| } | ||
|
|
||
| do { | ||
gjcairo marked this conversation as resolved.
Show resolved
Hide resolved
gjcairo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| loop: while true { | ||
| switch try self.stateMachine.nextOutboundMessage() { | ||
| case .sendMessage(let byteBuffer): | ||
| self.flushPending = true | ||
| context.write( | ||
| self.wrapOutboundOut(.data(.init(data: .byteBuffer(byteBuffer)))), | ||
| promise: nil | ||
| ) | ||
|
|
||
| case .noMoreMessages: | ||
| if let pendingTrailers = self.pendingTrailers { | ||
| self.flushPending = true | ||
| self.pendingTrailers = nil | ||
| context.write(self.wrapOutboundOut(pendingTrailers), promise: nil) | ||
| } | ||
| break loop | ||
|
|
||
| case .awaitMoreMessages: | ||
| break loop | ||
| } | ||
| } | ||
|
|
||
| if self.flushPending { | ||
| self.flushPending = false | ||
| context.flush() | ||
| } | ||
| } catch { | ||
| context.fireErrorCaught(error) | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.