Add GRPCClientStreamHandler #1838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
requested changes
Mar 22, 2024
Collaborator
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
This looks great but I don't think the logic in close is quite right.
Tests/GRPCHTTP2CoreTests/Client/GRPCClientStreamHandlerTests.swift
Outdated
Show resolved
Hide resolved
gjcairo
force-pushed
the
client-stream-handler
branch
from
53956e9 to
54c21eb
Compare
gjcairo
force-pushed
the
client-stream-handler
branch
from
54c21eb to
5c9931d
Compare
glbrntt
requested changes
Mar 26, 2024
glbrntt
approved these changes
Mar 26, 2024
Collaborator
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
Looks good modulo one question/nit
gjcairo
added
semver/none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
GRPCClientStreamHandler, which brings us a step closer to having a working HTTP2 transport implementation.