Skip to content

Conversation

@gjcairo
Copy link
Collaborator

@gjcairo gjcairo commented Mar 27, 2024

This PR fixes three bugs introduced in recent changes:

  • We weren't correctly handling the (invalid) scenario in which a server may send a data frame with EOS (instead of closing by sending status + trailers). This is now handled correctly by forwarding an internalError status code down the pipeline, and closing both client and server.
  • We were forwarding channel close when the close mode was output. However, because the H2 stream handler ignores the close mode and just closes down the whole channel upon receiving close, this was inadvertently closing the whole stream. We now only forward the close if the mode's all.
  • We were retrieving the grpc-status-message header using the canonical form, which caused us to only retrieve part of the original message if it included a comma. This has been fixed.

@gjcairo gjcairo requested a review from glbrntt March 27, 2024 13:45
@glbrntt glbrntt added the version/v2 Relates to v2 label Mar 27, 2024
@gjcairo gjcairo requested a review from glbrntt March 27, 2024 14:48
@gjcairo gjcairo force-pushed the client-handler-bugs branch from 2035bf1 to 5c13077 Compare March 27, 2024 15:09
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're leaking a promise but looks good otherwise

@gjcairo gjcairo requested a review from glbrntt March 27, 2024 15:22
@gjcairo gjcairo enabled auto-merge (squash) March 27, 2024 15:22
@gjcairo gjcairo merged commit 29bc8bc into grpc:main Mar 27, 2024
@gjcairo gjcairo deleted the client-handler-bugs branch March 27, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version/v2 Relates to v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants