-
Notifications
You must be signed in to change notification settings - Fork 435
Fix several bugs in GRPC stream handlers and state machine #1844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
requested changes
Mar 27, 2024
2035bf1 to
5c13077
Compare
glbrntt
requested changes
Mar 27, 2024
Collaborator
glbrntt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're leaking a promise but looks good otherwise
glbrntt
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes three bugs introduced in recent changes:
internalErrorstatus code down the pipeline, and closing both client and server.output. However, because the H2 stream handler ignores the close mode and just closes down the whole channel upon receivingclose, this was inadvertently closing the whole stream. We now only forward the close if the mode'sall.grpc-status-messageheader using the canonical form, which caused us to only retrieve part of the original message if it included a comma. This has been fixed.