Add server/client codegen options to protoc #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebello95
force-pushed
the
server-client-options
branch
from
0329885 to
5c5a79b
Compare
Implements support for specifying additional options for `protoc` gRPC codegen to exclude client and/or server code. Usage: ``` protoc TestEvent.proto --swiftgrpc_out=Client=true,Server=false:. ```
rebello95
force-pushed
the
server-client-options
branch
from
5c5a79b to
7fc2a63
Compare
rebello95
force-pushed
the
server-client-options
branch
from
7fc2a63 to
ea1f7c8
Compare
MrMage
approved these changes
May 12, 2018
Collaborator
MrMage
left a comment
MrMage
left a comment
There was a problem hiding this comment.
LGTM
Very clean, thanks a lot!
Collaborator
Author
|
For sure! I had considered some alternatives - personally I think it'd be really nice to be able to do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements support for specifying additional options for
protocgRPC codegen to exclude client and/or server code.Usage:
Also updated the readme with examples of all supported parameters.