Explicitly specify protoc plugin in Plugin test target #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change explicitly specifies the swift grpc ptotoc plugin in the `Plugin` directory, so users without `.` in the path can run the test target. Also add some build artifacts from the Plugin directory to .gitignore.
Describe how `protoc` finds the plugin binary in the path. A simple installation can be performed by copying the binary to a directory in the path. Also fix the example `protoc` invocation to match the Makefile by adding an explicit `--plugin` argument. Also add a few more files to .gitignore that are generated during plugin build/test.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change explicitly specifies the swift grpc ptotoc plugin in the
Plugindirectory, so users without.in the path can run the testtarget.
Also add some build artifacts from the Plugin directory to .gitignore.