Store the root certificates as a multi-line string literal. #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
My hunch is that CI is starting to get flaky again (no idea about the reasons, that should probably be investigated soon); closing and re-opening to re-trigger CI. |
Makes reviews easier and avoids expensive memory allocations and Base64 conversions at runtime. The signature of `roots_pem` changes from `String`-returning function to `String` constant; however, that method has only been made public a few days ago, so no users should be affected.
rebello95
approved these changes
Feb 22, 2019
Collaborator
rebello95
left a comment
rebello95
left a comment
There was a problem hiding this comment.
Approved with comment
Sources/RootsEncoder/main.swift
Outdated
| s += "\n" | ||
|
|
||
| s += "public func roots_pem() -> String {\n" | ||
| s += "public let roots_pem: String = \"\"\"\n" |
Collaborator
There was a problem hiding this comment.
Should we make this a constant using the k prefix (i.e., kRootsPem)?
Collaborator
Author
There was a problem hiding this comment.
Great idea! I've renamed the constant to kRootCertificates now; what do you think of that name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes reviews easier and avoids expensive memory allocations and Base64 conversions at runtime.
The signature of
roots_pemchanges fromString-returning function toStringconstant; however, that method has only been made public a few days ago, so no users should be affected.