Enforce request cardinality for unary-request calls also for the case of zero request messages being sent. #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of zero request messages being sent. Otherwise, the server will never respond to a call that gets closed without the client sending a response.
Collaborator
Author
|
/cc @glbrntt for review (can't request a review for you through the GitHub "Reviewers" list for some reason) |
…- it's easier to test this via HTTP1 than having to set up an HTTP2 client.
glbrntt
reviewed
Mar 5, 2019
Collaborator
Author
|
@glbrntt I've slightly extended the scope of this PR; please take another look. |
glbrntt
reviewed
Mar 5, 2019
Sources/SwiftGRPCNIO/CallHandlers/BidirectionalStreamingCallHandler.swift
Show resolved
Hide resolved
glbrntt
approved these changes
Mar 5, 2019
rebello95
approved these changes
Mar 5, 2019
|
|
||
| private func gRPCWebOKTrailers() -> Data { | ||
| var data = "grpc-status: 0\r\ngrpc-message: OK".data(using: .utf8)! | ||
Collaborator
There was a problem hiding this comment.
Looks like there's still trailing whitespace here
rebello95
reviewed
Mar 5, 2019
Collaborator
Author
|
@rebello95 please take another look, especially at the unresolved conversations. Feel free to squash-and-merge if you are satisfied with the current revision. |
rebello95
reviewed
Mar 5, 2019
|
|
||
| private func gRPCWebOKTrailers() -> Data { | ||
| var data = "grpc-status: 0\r\ngrpc-message: OK".data(using: .utf8)! | ||
Collaborator
There was a problem hiding this comment.
Looks like there's still trailing whitespace here
Collaborator
Author
|
Looks like I forgot to actually commit and push my fixes, sorry about that! @rebello95, please take one final look. |
rebello95
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the server will never respond to a call that gets closed without the client sending a response.
In addition, we introduce a method
sendErrorStatus(happy to discuss naming) onBaseCallHandlerthat sends an error status to the client while ensuring that all call context promises are fulfilled. This method is required (and needs to be overridden) because only the concrete call subclass knows which promises need to be fulfilled.