Skip to content

Conversation

@enricmacias
Copy link

Adds the changes from #358

@MrMage
Copy link
Collaborator

MrMage commented Apr 26, 2019

Thanks! Can this be applied to the Carthage project as well? And why did the BoringSSL dependency need to be deleted?

@enricmacias
Copy link
Author

The official BoringSSL doesn't support tvOS. But the one included in gRPC-Core library (BoringSSL-GRPC) it does. It is working fine with that library.

@enricmacias
Copy link
Author

About Carthage. I tried adding config.build_settings["TVOS_DEPLOYMENT_TARGET"] = "10.0" to fix-project-settings.rb, but for some reason it is not working as expected.

We may need to check which SDK target is using and set the appropriate deployment target for each one. I need some time/help for that, I don't really know how this ruby files are working at all.

@MrMage
Copy link
Collaborator

MrMage commented Apr 30, 2019

About Carthage. I tried adding config.build_settings["TVOS_DEPLOYMENT_TARGET"] = "10.0" to fix-project-settings.rb, but for some reason it is not working as expected.

We may need to check which SDK target is using and set the appropriate deployment target for each one. I need some time/help for that, I don't really know how this ruby files are working at all.

What is the error you are getting with that when running make project-carthage?

@MrMage MrMage mentioned this pull request May 7, 2019
@MrMage
Copy link
Collaborator

MrMage commented May 7, 2019

@enricmacias thank you! Two more things:

  1. We now have a merge conflict because the Carthage project on the master branch has changed in the meantime. I would suggest merging master into your branch, then running make project-carthage a second time.
  2. Could you please verify that the Carthage project builds on your machine? You should be able to open it in Xcode and then click "Build".

# Conflicts:
#	SwiftGRPC-Carthage.xcodeproj/GeneratedModuleMap/CNIONghttp2/module.modulemap
#	SwiftGRPC-Carthage.xcodeproj/project.pbxproj
#	SwiftGRPC-Carthage.xcodeproj/xcshareddata/xcschemes/SwiftGRPC-Package.xcscheme
@enricmacias
Copy link
Author

@MrMage I merged the master into my branch and run make project-carthage .

About the Carthage project building on my machine. I've already created a new tvOS project and installed SwiftGRPC through Carthage. The project compiled and run without a problem. Is that what you wanted for me to check?

@MrMage
Copy link
Collaborator

MrMage commented May 7, 2019

About the Carthage project building on my machine. I've already created a new tvOS project and installed SwiftGRPC through Carthage. The project compiled and run without a problem. Is that what you wanted for me to check?

Yes, that's perfect. Thank you!

I will close and re-open the PR to re-run CI.

@MrMage MrMage closed this May 7, 2019
@MrMage MrMage reopened this May 7, 2019
@MrMage MrMage merged commit 79ecfa5 into grpc:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants