-
Notifications
You must be signed in to change notification settings - Fork 435
Support tvOS #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tvOS #446
Conversation
|
Thanks! Can this be applied to the Carthage project as well? And why did the BoringSSL dependency need to be deleted? |
|
The official BoringSSL doesn't support tvOS. But the one included in gRPC-Core library (BoringSSL-GRPC) it does. It is working fine with that library. |
|
About Carthage. I tried adding We may need to check which SDK target is using and set the appropriate deployment target for each one. I need some time/help for that, I don't really know how this ruby files are working at all. |
What is the error you are getting with that when running |
|
@enricmacias thank you! Two more things:
|
# Conflicts: # SwiftGRPC-Carthage.xcodeproj/GeneratedModuleMap/CNIONghttp2/module.modulemap # SwiftGRPC-Carthage.xcodeproj/project.pbxproj # SwiftGRPC-Carthage.xcodeproj/xcshareddata/xcschemes/SwiftGRPC-Package.xcscheme
|
@MrMage I merged the master into my branch and run About the Carthage project building on my machine. I've already created a new tvOS project and installed SwiftGRPC through Carthage. The project compiled and run without a problem. Is that what you wanted for me to check? |
Yes, that's perfect. Thank you! I will close and re-open the PR to re-run CI. |
Adds the changes from #358