Add Speech-to-Text sample to illustrate one way to call a bidirectional streaming API. #516

timburks · 2019-07-21T00:55:30Z

No description provided.

streaming API.

MrMage · 2019-07-22T08:24:41Z

This is example is for the non-NIO implementation; do we really want to add new samples for that? (Also, using bidi APIs should be much more straightforward with the NIO version.)

timburks · 2019-07-22T17:29:07Z

@MrMage I got some questions about how to make streaming calls with the original APIs. I plan to add a NIO version when we have Cocoapods support for that.

MrMage

A few stylistic suggestions. If it were framework code, I'd probably request some more edits, but as an example it is sufficient I guess.

MrMage · 2019-07-23T10:10:49Z

Examples/Cocoapods/SpeechToText/Speech/AudioController.swift

+  static var sharedInstance = AudioController()
+
+  deinit {
+    AudioComponentInstanceDispose(remoteIOUnit!);


please remove the semicolons (also below)

MrMage · 2019-07-23T10:10:54Z

Examples/Cocoapods/SpeechToText/Speech/AudioController.swift

+  }
+
+  func prepare(specifiedSampleRate: Int) -> OSStatus {
+


nit: extra newline

MrMage · 2019-07-23T10:11:14Z

Examples/Cocoapods/SpeechToText/Speech/AudioController.swift

+      return status
+    }
+
+    let bus1 : AudioUnitElement = 1


nit: please remove the space before the colon (also below)

MrMage · 2019-07-23T10:11:32Z

Examples/Cocoapods/SpeechToText/Speech/AudioController.swift

+}
+
+func recordingCallback(
+  inRefCon:UnsafeMutableRawPointer,


nit: please add spaces after the colons

MrMage · 2019-07-23T10:11:39Z

Examples/Cocoapods/SpeechToText/Speech/AudioController.swift

+  inBusNumber:UInt32,
+  inNumberFrames:UInt32,
+  ioData:UnsafeMutablePointer<AudioBufferList>?) -> OSStatus {
+


nit: extra newlines

MrMage · 2019-07-23T10:43:08Z

Examples/Cocoapods/SpeechToText/Speech/SpeechRecognitionService.swift

+
+  static let sharedInstance = SpeechRecognitionService()
+
+  func streamAudioData(_ audioData: NSData, completion: @escaping SpeechRecognitionCompletionHandler) {


Can we use Data instead of NSData?

MrMage · 2019-07-23T10:43:39Z

Examples/Cocoapods/SpeechToText/Speech/SpeechRecognitionService.swift

+          print("update send error > \(error)")
+        }
+      }
+      //    self.signal(UIColor.green);


Remove this?

MrMage · 2019-07-23T10:44:24Z

Examples/Cocoapods/SpeechToText/Speech/ViewController.swift

+    self.button.setTitle("LISTENING (tap to stop)", for: .normal)
+    let audioSession = AVAudioSession.sharedInstance()
+    do {
+      try audioSession.setCategory(AVAudioSession.Category.record)


try! instead?

MrMage · 2019-07-23T10:44:36Z

Examples/Cocoapods/SpeechToText/Speech/ViewController.swift

+  @IBOutlet weak var textView: UITextView!
+  @IBOutlet weak var button: UIButton!
+
+  var audioData: NSMutableData!


Can we use Data?

MrMage · 2019-07-23T10:44:58Z

Examples/Cocoapods/SpeechToText/Speech/ViewController.swift

+
+    if (audioData.length > chunkSize) {
+      SpeechRecognitionService.sharedInstance.streamAudioData(audioData,
+                                                              completion:


Remove completion: and just pass the closure as a trailing closure instead?

glbrntt

Really cool example Tim!

glbrntt · 2019-07-25T09:16:03Z

Examples/Cocoapods/SpeechToText/README.md

+
+## Quickstart
+- Clone this repo and `cd` into this directory.
+- Run `./COMPILE-PROTOS.sh` to generate the Protocol Buffer and gRPC support files. Note that this requires protoc and the protoc-gen-swift and protoc-gen-swiftgrpc plugins. You can get the plugins by running `swift build` in the root of the grpc-swift repository.


nit: add protoc to the prerequisites

Do the plugins need to be statically linked? i.e. make plugins instead of swift build?

glbrntt · 2019-07-25T09:30:53Z

Examples/Cocoapods/SpeechToText/Speech/AppDelegate.swift

+
+  var window: UIWindow?
+
+  func application


nit: formatting looks off here

func application( _ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? = nil ) -> Bool { return true }

glbrntt · 2019-07-25T09:48:30Z

Examples/Cocoapods/SpeechToText/Speech/SpeechRecognitionService.swift

+import Foundation
+import SwiftGRPC
+
+let API_KEY = "YOUR_API_KEY"


FWIW: you can add a compiler warning (/error) here so that it's easier to find: #warning("You need to set your API Key")

glbrntt · 2019-07-25T09:52:50Z

@MrMage I got some questions about how to make streaming calls with the original APIs. I plan to add a NIO version when we have Cocoapods support for that.

Do we need to do the NIO example with Cocoapods? The Xcode 11 support for SwiftPM would make this easier. Also I'd be happy to put that example together.

MrMage · 2019-07-26T10:06:32Z

Do we need to do the NIO example with Cocoapods? The Xcode 11 support for SwiftPM would make this easier. Also I'd be happy to put that example together.

I guess we could be fine without it :-)

timburks · 2019-07-26T19:21:36Z

@glbrntt We don't need this to use Cocoapods - I think it would be fine/great to replace all Cocoapods examples with SwiftPM/Xcode 11 ones.

glbrntt · 2019-07-29T09:44:24Z

Examples/Cocoapods/SpeechToText/Speech/ViewController.swift

+      return
+    }
+    self.button.setTitle("LISTENING (tap to stop)", for: .normal)
+    let audioSession = AVAudioSession.sharedInstance()


Are these two lines necessary, they're also done in AudioController.prepare?

glbrntt · 2019-07-29T10:08:43Z

Examples/Cocoapods/SpeechToText/Speech/AudioController.swift

+}
+
+class AudioController {
+  var remoteIOUnit: AudioComponentInstance? // optional to allow it to be an inout argument


As far as I understand, this is the microphone, right? microphoneIOUnit would be clearer if so.

glbrntt · 2019-07-29T10:24:16Z

Examples/Cocoapods/SpeechToText/Speech/AudioController.swift

+    AudioComponentInstanceDispose(remoteIOUnit!)
+  }
+
+  func prepare(specifiedSampleRate: Int) -> OSStatus {


I know this is an example and the following isn't really the subject of the example but it would be useful to provide more of a description as to what each part of this is doing. Breaking it up into a couple of functions would also help readability!

glbrntt · 2019-07-29T10:25:43Z

Examples/Cocoapods/SpeechToText/Speech/AudioController.swift

+    // Set format for mic input (bus 1) on RemoteIO's output scope
+    var asbd = AudioStreamBasicDescription()
+    asbd.mSampleRate = sampleRate
+    asbd.mFormatID = kAudioFormatLinearPCM


Worth adding a comment saying that the initial request config is linked to this config.

MrMage · 2020-04-23T08:37:06Z

Closing this due to inactivity for now; please let us know if you would like to pick it up again.

Add Speech-to-Text sample to illustrate one way to call a bidirectional

ead1f18

streaming API.

timburks mentioned this pull request Jul 21, 2019

Trying to connect an http1.x server #497

Closed

4 tasks

MrMage closed this Jul 23, 2019

MrMage reopened this Jul 23, 2019

MrMage requested changes Jul 23, 2019

View reviewed changes

Incorporate Swift style feedback from @MrMage.

400cd4f

glbrntt reviewed Jul 25, 2019

View reviewed changes

glbrntt reviewed Jul 29, 2019

View reviewed changes

MrMage force-pushed the master branch from f4d5da3 to 9a8d023 Compare March 19, 2020 12:56

MrMage changed the base branch from master to cgrpc March 19, 2020 13:05

MrMage closed this Apr 23, 2020

Jake-Prickett mentioned this pull request Apr 29, 2020

Bidirectional Streaming iOS Example #776

Merged


		static let sharedInstance = SpeechRecognitionService()

		func streamAudioData(_ audioData: NSData, completion: @escaping SpeechRecognitionCompletionHandler) {

Add Speech-to-Text sample to illustrate one way to call a bidirectional streaming API. #516

Add Speech-to-Text sample to illustrate one way to call a bidirectional streaming API. #516

Uh oh!

Conversation

timburks commented Jul 21, 2019

Uh oh!

MrMage commented Jul 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timburks commented Jul 22, 2019

Uh oh!

MrMage left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

glbrntt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

glbrntt Jul 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

glbrntt commented Jul 25, 2019

Uh oh!

MrMage commented Jul 26, 2019

Uh oh!

timburks commented Jul 26, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MrMage commented Apr 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MrMage commented Jul 22, 2019 •

edited

Loading

glbrntt Jul 25, 2019 •

edited

Loading