Fallback to the hostname for TLS if a hostname override isn't provided #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: TLS does not work if a hostname override was not provided and hostname verification is enabled as only the override was provided to the NIOSSLClientHandler. Modifications: Provide the SSL handler with the override, if one is provided, or the hostname otherwise. Result: Fewer TLS failures.
Collaborator
|
Do we need tests for this? (Just asking.) |
kevints
reviewed
Jul 24, 2019
Collaborator
Author
|
@MrMage we probably should add tests here, yes. |
MrMage
approved these changes
Jul 25, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
TLS does not work if a hostname override was not provided and hostname
verification is enabled as only the override was provided to the
NIOSSLClientHandler.
Modifications:
Provide the SSL handler with the override, if one is provided, or the
hostname otherwise.
Result:
Fewer TLS failures.