Fix thread-safety issue in tests #551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrMage
approved these changes
Aug 16, 2019
glbrntt
commented
Aug 19, 2019
Collaborator
|
LGTM; please merge at your convenience after merge conflicts are resolved and CI has passed. |
Motivation: TSAN complained (once) about a data race in the connectivity state delegate in the tests. Modifications: Use a lock to make access to the expectations mutually exclusive. Result: TSAN is more happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
TSAN complained (once) about a data race in the connectivity state
delegate in the tests.
Modifications:
Use a lock to make access to the expectations mutually exclusive.
Result:
TSAN is more happy.