Make the backoff infinite #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The gRPC backoff continues ad infinitum (it is capped at a maximum timeout instead of growing exponentially forever). Our backoff terminates once it reaches the maximum backoff. Modifications: - Remove the upper limit on backoff generation so it is produced infinitely. - Remove a test which is no longer relevant. - Enable backoff by default Result: Client will try connecting until the user calls `close()`
Collaborator
|
Should we at least keep the option for users to stop retrying after the last backoff try? (Open to removing this now and re-adding this later only if it actually gets requested.) |
Collaborator
Author
I'd say remove and re-add if it gets requested. |
MrMage
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The gRPC backoff continues ad infinitum (it is capped at a maximum
timeout instead of growing exponentially forever). Our backoff
terminates once it reaches the maximum backoff.
Modifications:
Result:
Client will try connecting until the user calls
close()