Move generated interoperability test models to their own target. #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: To implement other interoperability tests (i.e. the connection backoff test) it would be convenient for the gRPC interoperability test models to be in a self contained target (instead of using symlinks). Modifications: - Move the interoperability test models into their own target - Rename the interoperability test implementation and CLI - Add missing imports Result: gRPC interoperability test models are in their own target.
MrMage
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
To implement other interoperability tests (i.e. the connection backoff test)
it would be convenient for the gRPC interoperability test models to be
in a self contained target (instead of using symlinks).
Modifications:
Result:
gRPC interoperability test models are in their own target.