Bump required version of NIOSSL #559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Prior to NIOSSL 2.4 it was possible to silently drop some certificates from a PEM bundle when loading from a file or buffer. These APIs were deprecated in 2.4 and our usage of them was causing compiler warnings. Modifications: Set the minimum version of NIOSSL to 2.4; update usage to the new APIs. Result: Fewer compiler warnings.
MrMage
approved these changes
Aug 20, 2019
Collaborator
MrMage
left a comment
MrMage
left a comment
There was a problem hiding this comment.
Feel free to merge after CI has passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Prior to NIOSSL 2.4 it was possible to silently drop some certificates
from a PEM bundle when loading from a file or buffer. These APIs were
deprecated in 2.4 and our usage of them was causing compiler warnings.
Modifications:
Set the minimum version of NIOSSL to 2.4; update usage to the new APIs.
Result:
Fewer compiler warnings.