Change access level for generated classes and methods to "internal" #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o "internal". "public" is replaced by a template parameter which is currently hard-coded to "internal".
Contributor
|
Is this related to #55? I was planning to compile my generated files in a framework, which is included in my app. Is this setup no longer supported? |
Member
Author
|
Yes, but if you need it, I'll add support for swift-proto's Visibility option. In the meantime, you can set the access level to public with a one-line change here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"public" is replaced by a template parameter which is currently hard-coded to "internal".