Update vendored gRPC-core to v1.23.0

[tsabirgaliev]

Motivation: gRPC v1.23.0 enables CFStream by default on iOS. This feature potentially can solve connectivity problems (#337)

[MrMage]

Upon a cursory look, this looks good. Were there any manual changes besides the redundant include that you needed to do, so we can document them?

[MrMage]

I'd also like for @rebello95 to take a look before merging this.

[tsabirgaliev]

@MrMage

Were there any manual changes besides the redundant include that you needed to do, so we can document them?

Nope. 9d8ab80 is the result of ./vendor-all.sh v1.23.0 and is reproducible (at least on my machine, I re-did it on clean HEAD a couple of times before committing). The only manual changes are in 12dbc2e and 338b680

[MrMage]

@tsabirgaliev thank you! Happy to merge this once @rebello95 approves as well.

[Westacular]

This implies it's safe to update the dependency on gRPC-Core in SwiftGRPC.podspec to ~> 1.23.0 as well. Should that also happen as part of this PR?

[tsabirgaliev]

@Westacular is Pods the only package spec shipped here? I’m afraid I’m not enough competent to cover them all :)

[MrMage]

Right, the Podspec also needs to be updated and the Carthage project generation script re-run as well.

…

On 29. Aug 2019, at 20:01, Tair Sabirgaliev ***@***.***> wrote: @Westacular is Pods the only package spec shipped here? I’m afraid I’m not enough competent to cover them all :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[MrMage]

We should have documentation somewhere on all the steps to do when updating the vendor gRPC. Or just look at the previous update PR :-)

…

On 29. Aug 2019, at 20:01, Tair Sabirgaliev ***@***.***> wrote: @Westacular is Pods the only package spec shipped here? I’m afraid I’m not enough competent to cover them all :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[tsabirgaliev]

Or just look at the previous update PR

@MrMage haha, good catch :) it is exactly what I did. I even copy-pasted the commit messages.

[MrMage]

I think we should indeed update the Podspec and the Carthage project in this PR as well.

[tsabirgaliev]

@MrMage do we need to also bump the grpc-swift version in Podspec?

[MrMage]

@MrMage do we need to also bump the grpc-swift version in Podspec?

No, one of the team will do that when releasing the next version of Swift gRPC.

[tsabirgaliev]

@MrMage I'm sorry, I don't get how to update the Carthage project. Is it just make project-carthage in this case?

[MrMage]

@MrMage I'm sorry, I don't get how to update the Carthage project. Is it just make project-carthage in this case?

Yes, that should be it.

[MrMage]

Thank you for the changes, @tsabirgaliev! Once the next release is cut, the library will officially use gRPC-Core 1.23. Until then, you can already use it by using the master branch.

[rebello95]

Thanks for doing this! Sorry I was unable to review - was OOO last week.