Allow timeouts to be rounded so they may comply with the spec #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The gRPC spec dictates that timeouts may be no longer than 8 digits long. As such methods for creating `GRPCTimeout`s all throw if the given timeout is not valid. In the vast majority of cases this is not actually an issue and having to handle the exception can be a pain. Modifications: Add non-throwing factory methods to `GRPCTimeout` which round the timeout so that it may be encoded over the wire. Result: Timeouts are easier to create.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The gRPC spec dictates that timeouts may be no longer than 8 digits
long. As such methods for creating
GRPCTimeouts all throw if the giventimeout is not valid. In the vast majority of cases this is not actually
an issue and having to handle the exception can be a pain.
Modifications:
Add non-throwing factory methods to
GRPCTimeoutwhich round thetimeout so that it may be encoded over the wire.
Result:
Timeouts are easier to create.