Replace Commander usage with our own CLI parsing #570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We're relying on third-party code for parsing CLI arguments, however, this is only being used for interop tests and the echo example and isn't required to use the GRPC module. However when another package depends on GRPC, SwiftPM will also bring in the third-party code (and all of its transitive dependencies) even if no targets used by the other package rely on that code. Modifications: Remove usages of "Commander" and replace with some basic CLI parsing. Result: Our CLIs are less colorful, but we drop a dependency.
|
|
MrMage
approved these changes
Aug 30, 2019
Collaborator
MrMage
left a comment
MrMage
left a comment
There was a problem hiding this comment.
Nice, no more third-party dependencies!
| Commands: | ||
| server [--tls|--notls] PORT Starts the echo server on the given port. | ||
| client [--tls|--notls] HOST PORT RPC MESSAGE Connects to the echo server on the given host | ||
| host and port and calls the RPC with the |
Collaborator
There was a problem hiding this comment.
super-nit: is it intentional that this line is intended more than "Connects" on the previous one?
Collaborator
Author
There was a problem hiding this comment.
It is intentional, it didn't look right as just a wall of text before. Looking again I think un-indenting and adding a new line between client and server would look better.
Collaborator
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We're relying on third-party code for parsing CLI arguments, however,
this is only being used for interop tests and the echo example and isn't
required to use the GRPC module. However when another package depends on
GRPC, SwiftPM will also bring in the third-party code (and all of its
transitive dependencies) even if no targets used by the other package
rely on that code.
Modifications:
Remove usages of "Commander" and replace with some basic CLI parsing.
Result:
Our CLIs are less colorful, but we drop a dependency.