Update Travis script #571
Merged
Update Travis script #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Recently the CLI parsing library was dropped in favour of our own CLI parsing. However, the CI script for running interop tests was not updated. Modifications: Update the CI script to run interop tests. Also update an off-by-one error in the server CLI parsing that forced users to provide an optional argument. Result: CI shouldn't error because of CLI failures.
Collaborator
Author
|
sorry about this one! 🤦♂️ |
MrMage
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Recently the CLI parsing library was dropped in favour of our own CLI
parsing. However, the CI script for running interop tests was not
updated.
Modifications:
Update the CI script to run interop tests. Also update an off-by-one
error in the server CLI parsing that forced users to provide an optional
argument.
Result:
CI shouldn't error because of CLI failures.