Add HelloWorld example #590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: To help users get started quickly with gRPC Swift it would be useful to have a "hello world" example. grpc.io has such examples for a number of languages: https://grpc.io/docs/quickstart/ but not for Swift. Another motivating factor for this change was feedback from the gRPC on the SSWG draft proposal suggesting that it would be useful to frame the proposal from a canonical example, either "HelloWorld" or "RouteGuide". Modifications: - Add a "HelloWorld" example - Create a "quick-start" guide modelled on those on grpc.io Result: - No functional changes - Another example and tutorial
MrMage
approved these changes
Sep 27, 2019
Collaborator
MrMage
left a comment
MrMage
left a comment
There was a problem hiding this comment.
Just a few non-mandatory suggestions.
Collaborator
|
LGTM |
glbrntt
added a commit
to glbrntt/grpc-swift
that referenced
this pull request
Sep 27, 2019
Motivation: a30043a (grpc#590) introduced a 'Hello World' example and tutorial to help new gRPC Swift users. A more in-depth tutorial would be useful as a next-step for those users. Modifications: Add a tutorial based on the "route guide" service as per https://grpc.io/docs/tutorials/ Move parts of the `README.md` into separate documenation files in `docs/` Result: - Another gRPC tutorial - Easier to find documenation
glbrntt
added a commit
to glbrntt/grpc-swift
that referenced
this pull request
Sep 27, 2019
Motivation: a30043a (grpc#590) introduced a 'Hello World' example and tutorial to help new gRPC Swift users. A more in-depth tutorial would be useful as a next-step for those users. Modifications: Add a tutorial based on the "route guide" service as per https://grpc.io/docs/tutorials/ Move parts of the `README.md` into separate documenation files in `docs/` Result: - Another gRPC tutorial - Easier to find documenation
glbrntt
added a commit
that referenced
this pull request
Sep 30, 2019
Motivation: a30043a (#590) introduced a 'Hello World' example and tutorial to help new gRPC Swift users. A more in-depth tutorial would be useful as a next-step for those users. Modifications: Add a tutorial based on the "route guide" service as per https://grpc.io/docs/tutorials/ Move parts of the `README.md` into separate documenation files in `docs/` Result: - Another gRPC tutorial - Easier to find documenation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
To help users get started quickly with gRPC Swift it would be useful to
have a "hello world" example. grpc.io has such examples for
a number of languages: https://grpc.io/docs/quickstart/ but not for Swift.
Another motivating factor for this change was feedback from the gRPC team
on the SSWG draft proposal suggesting that it would be useful to frame the
proposal from a canonical example, either "HelloWorld" or "RouteGuide".
Modifications:
Result: