Provide a channel handler using the client state machine #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: 8db70dd (grpc#580) introduced a client state machine which enables us to reduce the number of channel handlers the client has and confine much of the stream state tracking to a single place. However, none of our channel handlers were designed to use it! Modifications: Create a client channel handler using the aforementioned state machine and update the state machine to talk in HTTP/2 concepts to avoid having to use an additional handler to translate between HTTP/1 and HTTP/2 concepts. Result: Functionally, nothing, as the channel handler is not yet used.
MrMage
reviewed
Oct 15, 2019
Collaborator
MrMage
left a comment
MrMage
left a comment
There was a problem hiding this comment.
Looks very good overall; no objections to the logic. My biggest concern would be about dropping gRPC-Web support; not sure if we can/should simply leave transcoding to an out-of-process proxy dedicated to that.
7 tasks
Collaborator
Author
|
@MrMage are you okay with these changes / can I merge? |
MrMage
approved these changes
Oct 25, 2019
Collaborator
Yes, sorry! |
Collaborator
Author
No problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
8db70dd (#580) introduced a client state machine which enables us to
reduce the number of channel handlers the client has and confine much of
the stream state tracking to a single place. However, none of our
channel handlers were designed to use it!
Modifications:
Create a client channel handler using the aforementioned state machine
and update the state machine to talk in HTTP/2 concepts to avoid having
to use an additional handler to translate between HTTP/1 and HTTP/2
concepts.
Result:
Functionally, nothing, as the channel handler is not yet used.