Workaround for SR-11564 #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: gRPC Swift crashes when running any RPC on iOS when built with Xcode 11.2 beta (see issue: grpc#605). Modifications: - Add methods `override`ing the `scheduleTimeout` method on the different client response channel handler subclasses. The overriden methods just explicitly call the method in the `super` class. Result: No crash on iOS when compiled with Xcode 11.2 beta.
MrMage
approved these changes
Oct 10, 2019
Collaborator
MrMage
left a comment
MrMage
left a comment
There was a problem hiding this comment.
Please add a TODO to remove this again soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
gRPC Swift crashes when running any RPC on iOS when built with Xcode
11.2 beta (see issue: #605).
Modifications:
overrideing thescheduleTimeoutmethod on the differentclient response channel handler subclasses. The overriden methods just
explicitly call the method in the
superclass.Result:
No crash on iOS when compiled with Xcode 11.2 beta.