Correctly set the authority to the host rather than scheme #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
glbrntt
approved these changes
Nov 26, 2019
Collaborator
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
Ah great catch, thank you so much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the HTTP2 spec, the
:authorityheader should include the authority portion of the URI.https://http2.github.io/http2-spec/#HttpRequest
https://tools.ietf.org/html/rfc3986#section-3.2
Certain proxies that read the host from the authority field fail to forward the RPC to the correct service. This change sets the authority field to the target host.