Skip to content

Conversation

@glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Dec 2, 2019

Motivation:

The NaturalLanguage example did not compile because of breaking API
changes between pre-release version.

Modifications:

Fix compilation issues.

Result:

NaturalLanguage example compiles.

Motivation:

The NaturalLanguage example did not compile because of breaking API
changes between pre-release version.

Modifications:

Fix compilation issues.

Result:

NaturalLanguage example compiles.
@MrMage
Copy link
Collaborator

MrMage commented Dec 2, 2019

Fixes #642.

@glbrntt
Copy link
Collaborator Author

glbrntt commented Dec 2, 2019

@MrMage just an FYI: I didn't move this to the Sources/Examples directory since it has additional dependencies which aren't required by the library (i.e. google-auth-library-swift).

When I get around to removing the other examples/tidying up I'll add this to the CI.

@glbrntt glbrntt merged commit 3b6a69e into grpc:nio Dec 4, 2019
@glbrntt glbrntt deleted the gb-fix-natural-language-example branch December 4, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants