Implement status message encoding and decoding without Foundation #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
See also #644 |
MrMage
approved these changes
Dec 3, 2019
Collaborator
MrMage
left a comment
MrMage
left a comment
There was a problem hiding this comment.
FYI, here is a blazing-fast HTML-escaping routine in case you want to try optimizing this further: https://github.com/vapor/template-kit/blob/master/Sources/TemplateKit/Utilities/HTMLEscape.swift
(At least pre-Swift-5.1, I was unable to get similar performance without using unsafe methods.)
Motivation: Percent encoding and decoding go via Foundation so we really get a bridges CFString. Modifications: Implement the percent encoding and decoding without Foundation. Result: - Less Obj-C - A small perf gain when encoding/decoding status messages: - before: percent_encode_decode_10k_status_messages: 67,63,62,63,65,62,63,65,63,63 - after: percent_encode_decode_10k_status_messages: 49,43,43,43,43,43,43,45,44,44
glbrntt
force-pushed
the
gb-status-marshalling
branch
from
a94907e to
eb818b0
Compare
Collaborator
Author
|
Thanks for that @MrMage! I added the length-check fast path since I reckon that's very common and a pretty big win: |
MrMage
reviewed
Dec 4, 2019
Collaborator
MrMage
left a comment
MrMage
left a comment
There was a problem hiding this comment.
Do we have tests that ensure the correctness of the algorithm?
Collaborator
Author
Collaborator
Author
|
Admittedly there aren't many of them though. |
Collaborator
|
Thanks! I must have missed those. LGTM from my side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Percent encoding and decoding go via Foundation so we really get a
bridges CFString.
Modifications:
Implement the percent encoding and decoding without Foundation.
Result: