Skip to content

Make GRPCClientChannelHandler underscore internal #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2019
Merged

Make GRPCClientChannelHandler underscore internal #662

merged 2 commits into from
Dec 16, 2019

Conversation

@glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Dec 16, 2019

See #657

@glbrntt glbrntt requested a review from MrMage December 16, 2019 12:19
MrMage
MrMage reviewed Dec 16, 2019
View reviewed changes
Copy link
Collaborator

@MrMage MrMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need to be public at all?

@glbrntt
Copy link
Collaborator Author

glbrntt commented Dec 16, 2019

It's used in one of the perf tests.

@MrMage
Copy link
Collaborator

MrMage commented Dec 16, 2019

Ah, thanks. Then we can't @testable import it, I guess. But could you document why it is public at all in the comment stating that it is not public API?

@glbrntt
Copy link
Collaborator Author

glbrntt commented Dec 16, 2019

Ah, thanks. Then we can't @testable import it, I guess. But could you document why it is public at all in the comment stating that it is not public API?

Done!

@glbrntt glbrntt merged commit 08a5dd7 into grpc:nio Dec 16, 2019
@glbrntt glbrntt deleted the gb-api-work-5 branch December 16, 2019 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrMage MrMage MrMage approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@glbrntt @MrMage