Skip to content

Conversation

@glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Jan 8, 2020

Motivation:

We should run our CI against development versions of Swift so that we
can catch any language regressions, bugs, etc. before release.

Modifications:

  • Add Swift Development 5.2 to run unit tests for all PRs.
  • Allow the job to be failable.
  • Update Xcode for CI to 11.3

Result:

Pre-release Swift running as part of CI on Linux.

Motivation:

We should run our CI against development versions of Swift so that we
can catch any language regressions, bugs, etc. before release.

Modifications:

- Add Swift Development 5.2 to run unit tests for all PRs.
- Allow the job to be failable.
- Update Xcode for CI to 11.3

Result:

Pre-release Swift running as part of CI on Linux.
@glbrntt glbrntt requested a review from MrMage January 8, 2020 14:50
Copy link
Collaborator

@MrMage MrMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what does language: minimal mean?

@glbrntt
Copy link
Collaborator Author

glbrntt commented Jan 9, 2020

Each job has a language, depending on that language additional keys are allowed in the configuration and various dependencies are brought in. If language is omitted it defaults to ruby (which is why the UI would says "Ruby" in a couple of places). Travis thinks that "swift" means xcodeproject / iOS app so brings in things like cocoa pods. Minimal is, well, minimal. Practically speaking I don't think the change will make a noticeable difference.

@glbrntt glbrntt merged commit b9fbd6b into grpc:nio Jan 9, 2020
@glbrntt glbrntt deleted the gb-swift-development-in-ci branch January 9, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants