Skip to content

Added .git ending for swift-log #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2020
Merged

Added .git ending for swift-log #760

merged 1 commit into from
Mar 24, 2020

Conversation

@fabianfett
Copy link
Collaborator

@fabianfett fabianfett commented Mar 24, 2020

Motivation

  • Xcode doesn't seem smart enough to checkout swift-log if it is missing .git.
  • all other dependencies have a .git at the end.

Changes

  • in Package.swift: swift-log -> swift-log.git

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 24, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

glbrntt
glbrntt approved these changes Mar 24, 2020
View reviewed changes
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fabianfett!

@glbrntt glbrntt added nio 🔨 semver/patch No public API change. labels Mar 24, 2020
@glbrntt glbrntt merged commit abc32f7 into grpc:master Mar 24, 2020
@fabianfett fabianfett deleted the ff-swift-log.git branch March 24, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glbrntt glbrntt glbrntt approved these changes

Assignees

No one assigned

Labels

🔨 semver/patch No public API change.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fabianfett @glbrntt