Update CgRPC to v1.24.3

[glbrntt]

No description provided.

[MrMage]

Thank you for taking the time to do this!

I was able to scroll to the bottom and find the changed scripts. Looks good overall; are there any relevant learnings you could share to make this process easier in case it needs to be repeated in the future?

[glbrntt]

I was able to scroll to the bottom and find the changed scripts. Looks good overall; are there any relevant learnings you could share to make this process easier in case it needs to be repeated in the future?

Sorry, I should've mentioned that changes to the scripts were in one commit and the output in the other!

I think the main takeaway is that the divide between shim code and vendored code needs to be much clearer. Ideally the script should produce the whole CgRPC module by copying in the vendored code and then copying in any required shim code. I ran into problems where it wasn't clear if code was required or leftover from a previous time the script was run. The few bugs in the vendoring scripts also didn't help! That said, I don't think it's worth our time doing this because this is effectively EOL anyway.

[MrMage]

I think the main takeaway is that the divide between shim code and vendored code needs to be much clearer. Ideally the script should produce the whole CgRPC module by copying in the vendored code and then copying in any required shim code. I ran into problems where it wasn't clear if code was required or leftover from a previous time the script was run. The few bugs in the vendoring scripts also didn't help! That said, I don't think it's worth our time doing this because this is effectively EOL anyway.

👍

LGTM from my side!