Add high level differences between 1.x and 0.y to README #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: - There's been some confusion recently around the two versions of gRPC. - See also: grpc#808 Modifications: - Add high level differences between two versions to README - Add current SemVer version build badge to make version more obvious - Explain difference between two example directories in README Result: Better documentation
MrMage
approved these changes
May 27, 2020
Collaborator
MrMage
left a comment
MrMage
left a comment
There was a problem hiding this comment.
That's great, thank you!
Ideally, we would also have a dedicated guide on how to switch, but I guess that'll have to wait due to bandwidth concerns... (I also haven't experienced the transition on the client side myself yet, so can't report on that.)
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Collaborator
Author
Agreed, I didn't have time to do all of that, but this felt like a lot of benefit for little effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Modifications:
Result:
Better documentation
This change is