Skip to content

Conversation

@JosephSanjaya
Copy link
Collaborator

📱 Description

  • Integrate with revenue cat
  • Implement csv exporter and launcher
  • Implement pdf renderer and exporter

Platform

  • Android
  • iOS
  • Games-Unity
  • DevOps (AWS)
  • Website
  • C/Golang

🎯 Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 🔧 Refactoring (code change that neither fixes a bug nor adds a feature)
  • 📚 Documentation update
  • 🎨 UI/UX improvement
  • ⚡ Performance improvement
  • 🧪 Test addition or improvement

🎯 Steps to reproduce and/or Test

  1. Please always update submodules first
  2. If you pull from main repository, make sure the general purpose and the main repo on branch js/feat/iap
  3. Sync the projects, you should see 2 app configuration app and general-purpose-app
  4. both can be run app will launch normal apps, but general-purpose-app will launch test app for faster debugging.
  5. Use account that has transactions, if not then the button to export should not shown
  6. Click export then continue the flow

📋 Changes

  • Integrate with revenue cat
  • Implement csv exporter and launcher
  • Implement pdf renderer and exporter

🔗 Related Issues

🧪 Tests Status

  • Tests ran successfully locally?
  • Added more tests? How many?
  • Code coverage percentage of the codebase: __%

Uploading CleanShot 2025-10-06 at 00.34.13.mp4…

🎯 Reviewers

@kcw-grunt, @josikie

@JosephSanjaya JosephSanjaya self-assigned this Oct 5, 2025
@JosephSanjaya JosephSanjaya marked this pull request as draft October 5, 2025 17:38
@josikie
Copy link
Collaborator

josikie commented Oct 5, 2025

Amazing, I'll test at it, also please resolve the conflicts, thank you! @JosephSanjaya

@kcw-grunt
Copy link
Collaborator

Thanks @JosephSanjaya . Once the general purpose repo is tested and approved I will focus on this PR.

Copy link
Collaborator

@kcw-grunt kcw-grunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need rebase (the private and build repo) before reviewing @JosephSanjaya

@JosephSanjaya
Copy link
Collaborator Author

Rebased!

kcw-grunt and others added 3 commits October 7, 2025 00:27
This commit migrates the project's build logic to use a centralized version catalog (`grunt`) and updates submodule references.

Specific changes include:

*   **Submodule Updates:**
    *   Updated `gruntsoftware-build-logic` submodule pointer.
    *   Updated `modules/private-general-purpose` submodule pointer.
*   **Build Configuration (`settings.gradle.kts`):**
    *   Removed the conditional loading of the `games` version catalog.
    *   Added a `grunt` version catalog loaded from `gruntsoftware-build-logic/gradle/libs.versions.toml`.
    *   Changed the included module from `:modules:private-general-purpose:content` to `:modules:private-general-purpose:games`.
    *   Removed conditional inclusion logic for `:modules:private-general-purpose:content`.
*   **Root `build.gradle.kts`:**
    *   Updated plugin aliases from `libs.plugins.android.*` to `grunt.plugins.android.*`.
*   **App `build.gradle.kts`:**
    *   Updated plugin alias for `com.android.application` from `libs` to `grunt`.
    *   Updated the `games` module dependency to `implementation(project(":modules:private-general-purpose:games"))` and removed the conditional logic for `findProject(":modules:games:content")`.
    *   Updated various dependencies to use the `grunt` version catalog (e.g., `grunt.androidx.core.ktx`, `grunt.androidx.compose.bom`, `grunt.bundles.androidx.compose`, `grunt.material`).
*   **Version Catalog (`gradle/libs.versions.toml`):**
    *   Removed versions for `agp` and `androidx-core-ktx`.
    *   Removed versions for `androidx-compose-bom`, `androidx-activity-compose`, and `androidx-fragment-compose`.
    *   Removed `androidx-core` library alias.
    *   Removed various `androidx-compose` library aliases and the `androidx-compose` bundle.
    *   Removed `android-application` and `android-library` plugin aliases.
@JosephSanjaya JosephSanjaya marked this pull request as ready for review October 6, 2025 17:31
@kcw-grunt kcw-grunt self-requested a review October 7, 2025 13:37
This commit adds the `kotlinx-collections-immutable` library, version 0.4.0, to the project's dependencies.
@JosephSanjaya
Copy link
Collaborator Author

Add simple test, and fix failed pipeline @kcw-grunt, PR is ready

@kcw-grunt
Copy link
Collaborator

Add simple test, and fix failed pipeline @kcw-grunt, PR is ready
Yup Im running through sync and func test @JosephSanjaya Did you see my question re namespace?

@JosephSanjaya
Copy link
Collaborator Author

Add simple test, and fix failed pipeline @kcw-grunt, PR is ready
Yup Im running through sync and func test @JosephSanjaya Did you see my question re namespace?

did you mean the chilli one?

@JosephSanjaya
Copy link
Collaborator Author

ohh that color is moved to core modules on general purpose, hmm because that already merged i will fix that on next PR on general purpose repo is that okay? @kcw-grunt ?

@kcw-grunt
Copy link
Collaborator

Add simple test, and fix failed pipeline @kcw-grunt, PR is ready
Yup Im running through sync and func test @JosephSanjaya Did you see my question re namespace?

did you mean the chilli one?

No I meant this :
Screenshot 2025-10-07 at 15 44 23

@JosephSanjaya
Copy link
Collaborator Author

JosephSanjaya commented Oct 7, 2025

Add simple test, and fix failed pipeline @kcw-grunt, PR is ready
Yup Im running through sync and func test @JosephSanjaya Did you see my question re namespace?

did you mean the chilli one?

No I meant this : Screenshot 2025-10-07 at 15 44 23

that was also coming from general purpose repo. i move the theme for reusability . i think that was the namespace at the beginning of games repo.

i will change it on next PR if you want me to change that. @kcw-grunt

@kcw-grunt
Copy link
Collaborator

Add simple test, and fix failed pipeline @kcw-grunt, PR is ready
Yup Im running through sync and func test @JosephSanjaya Did you see my question re namespace?

did you mean the chilli one?

No I meant this : Screenshot 2025-10-07 at 15 44 23

that was also coming from general purpose repo. i move the theme for reusability . i think that was the namespace at the beginning of games repo.

i will change it on next PR if you want me to change that. @kcw-grunt

Thats fine. I'm less worried about that...I just wanted to understand.
But having chili needs to be fixed because all of our assets are already using that spelling. Looking forward to seeing that taken care of next time @JosephSanjaya

@JosephSanjaya
Copy link
Collaborator Author

Add simple test, and fix failed pipeline @kcw-grunt, PR is ready
Yup Im running through sync and func test @JosephSanjaya Did you see my question re namespace?

did you mean the chilli one?

No I meant this : Screenshot 2025-10-07 at 15 44 23

that was also coming from general purpose repo. i move the theme for reusability . i think that was the namespace at the beginning of games repo.
i will change it on next PR if you want me to change that. @kcw-grunt

Thats fine. I'm less worried about that...I just wanted to understand. But having chili needs to be fixed because all of our assets are already using that spelling. Looking forward to seeing that taken care of next time @JosephSanjaya

Okay Noted @kcw-grunt , i think that name is carried out from main repo, because im not changing anything, just moving the places. will fix it later

Updates the import paths for the core presentation module from `ltd.grunt.brainwallet.core.presentation` to `com.grunt.brainwallet.core.presentation`. This refactoring touches multiple UI components and initializers across the `app` module to align with the new package structure.

Additionally, this commit corrects a typo in `SeedWordItem.kt`, changing the error color variable from `chilli` to `chili` to match the theme definition.

Finally, the submodule pointer for `private-general-purpose` is updated.
@JosephSanjaya
Copy link
Collaborator Author

Change branch on general-purpose, it should be ready to check @kcw-grunt

Copy link
Collaborator

@kcw-grunt kcw-grunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

import com.brainwallet.ui.screens.home.composable.settingsrows.SecurityDetail
import com.brainwallet.ui.screens.home.composable.settingsrows.SettingRowItem
import com.brainwallet.ui.screens.home.composable.settingsrows.ThemeSettingRowItem
import com.brainwallet.ui.theme.BrainwalletAppTheme
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we switching the namespace from
com.brainwallet vs ltd.grunt.brainwallet @JosephSanjaya ?

Copy link
Collaborator

@josikie josikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @JosephSanjaya

@kcw-grunt kcw-grunt added the enhancement New feature or request label Oct 9, 2025
@JosephSanjaya JosephSanjaya merged commit 0b46614 into develop Oct 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

android enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants