-
Notifications
You must be signed in to change notification settings - Fork 2
feat(export-transactions): implement in-app purchase #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Amazing, I'll test at it, also please resolve the conflicts, thank you! @JosephSanjaya |
|
Thanks @JosephSanjaya . Once the general purpose repo is tested and approved I will focus on this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need rebase (the private and build repo) before reviewing @JosephSanjaya
|
Rebased! |
This commit migrates the project's build logic to use a centralized version catalog (`grunt`) and updates submodule references.
Specific changes include:
* **Submodule Updates:**
* Updated `gruntsoftware-build-logic` submodule pointer.
* Updated `modules/private-general-purpose` submodule pointer.
* **Build Configuration (`settings.gradle.kts`):**
* Removed the conditional loading of the `games` version catalog.
* Added a `grunt` version catalog loaded from `gruntsoftware-build-logic/gradle/libs.versions.toml`.
* Changed the included module from `:modules:private-general-purpose:content` to `:modules:private-general-purpose:games`.
* Removed conditional inclusion logic for `:modules:private-general-purpose:content`.
* **Root `build.gradle.kts`:**
* Updated plugin aliases from `libs.plugins.android.*` to `grunt.plugins.android.*`.
* **App `build.gradle.kts`:**
* Updated plugin alias for `com.android.application` from `libs` to `grunt`.
* Updated the `games` module dependency to `implementation(project(":modules:private-general-purpose:games"))` and removed the conditional logic for `findProject(":modules:games:content")`.
* Updated various dependencies to use the `grunt` version catalog (e.g., `grunt.androidx.core.ktx`, `grunt.androidx.compose.bom`, `grunt.bundles.androidx.compose`, `grunt.material`).
* **Version Catalog (`gradle/libs.versions.toml`):**
* Removed versions for `agp` and `androidx-core-ktx`.
* Removed versions for `androidx-compose-bom`, `androidx-activity-compose`, and `androidx-fragment-compose`.
* Removed `androidx-core` library alias.
* Removed various `androidx-compose` library aliases and the `androidx-compose` bundle.
* Removed `android-application` and `android-library` plugin aliases.
6d7c6ca to
2b41ade
Compare
2b41ade to
e6204bc
Compare
This commit adds the `kotlinx-collections-immutable` library, version 0.4.0, to the project's dependencies.
e6204bc to
2fcb1b2
Compare
|
Add simple test, and fix failed pipeline @kcw-grunt, PR is ready |
|
did you mean the chilli one? |
|
ohh that color is moved to core modules on general purpose, hmm because that already merged i will fix that on next PR on general purpose repo is that okay? @kcw-grunt ? |
|
that was also coming from general purpose repo. i move the theme for reusability . i think that was the namespace at the beginning of games repo. i will change it on next PR if you want me to change that. @kcw-grunt |
Thats fine. I'm less worried about that...I just wanted to understand. |
Okay Noted @kcw-grunt , i think that name is carried out from main repo, because im not changing anything, just moving the places. will fix it later |
Updates the import paths for the core presentation module from `ltd.grunt.brainwallet.core.presentation` to `com.grunt.brainwallet.core.presentation`. This refactoring touches multiple UI components and initializers across the `app` module to align with the new package structure. Additionally, this commit corrects a typo in `SeedWordItem.kt`, changing the error color variable from `chilli` to `chili` to match the theme definition. Finally, the submodule pointer for `private-general-purpose` is updated.
|
Change branch on general-purpose, it should be ready to check @kcw-grunt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| import com.brainwallet.ui.screens.home.composable.settingsrows.SecurityDetail | ||
| import com.brainwallet.ui.screens.home.composable.settingsrows.SettingRowItem | ||
| import com.brainwallet.ui.screens.home.composable.settingsrows.ThemeSettingRowItem | ||
| import com.brainwallet.ui.theme.BrainwalletAppTheme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we switching the namespace from
com.brainwallet vs ltd.grunt.brainwallet @JosephSanjaya ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks @JosephSanjaya


📱 Description
Platform
🎯 Type of Change
🎯 Steps to reproduce and/or Test
js/feat/iapappandgeneral-purpose-appappwill launch normal apps, but general-purpose-app will launch test app for faster debugging.📋 Changes
🔗 Related Issues
🧪 Tests Status
Uploading CleanShot 2025-10-06 at 00.34.13.mp4…
🎯 Reviewers
@kcw-grunt, @josikie