[APT-1573] [APT-1574]: Subscriber notification for private Github links #119
Conversation
oredavids
requested review from
eak12913,
ebeneliason and
pete0emerson
as code owners
|
✔️ Deploy Preview for pensive-meitner-faaeee ready! 🔨 Explore the source changes: f96d6f6 🔍 Inspect the deploy log: https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/61e0a5fa43c0d90007df0a49 😎 Browse the preview: https://deploy-preview-119--pensive-meitner-faaeee.netlify.app |
oredavids
changed the title
ebeneliason
force-pushed
the
subscriber-notification
branch
from
09edc2c to
efddf16
Compare
…k-io/docs into subscriber-notification # Conflicts: # src/components/Modal.module.css # src/components/Modal.tsx
eak12913
changed the title
|
@eak12913 I noticed that when I clicked the checkbox(to prevent future notifications) and then hit the "Cancel Option"; I got the notification on the next link that I clicked. This is minor but shouldn't we always respect the notification preference? |
| // If the user checked to never see this notice but subsequently cancels we will disregard their selection. We will | ||
| // only stop showing this notice if they check the box and then proceed to GitHub |
There was a problem hiding this comment.
I see that this is intentional - Is there a particular reason for disregarding it?
There was a problem hiding this comment.
We can discuss this quickly next time we speak - but for the purpose of this PR we do want to have that behavior. It's a slightly better user experience as it applies your wishes only after you've chosen to follow the link forward. Otherwise you can get into a s situation where you dind't mean to dismiss the thing and never see it again.
3 participants
This PR adds a modal popup that will display to all users when they click on a link that takes them to
github.com/gruntwork-io/*. The modal will warn users about getting 404s if they are not subscribers. There's also the ability to indicate that the warning should never be shown again.