Skip to content

Conversation

@oredavids
Copy link
Contributor

@oredavids oredavids commented Jan 4, 2022

What does this PR do?

  • Updates to docusaurus version 2-beta-14
  • Fixes meta title for home page
  • Removes unnecessary pages

APT-1554

@netlify
Copy link

netlify bot commented Jan 4, 2022

✔️ Deploy Preview for pensive-meitner-faaeee ready!

🔨 Explore the source changes: e880944

🔍 Inspect the deploy log: https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/61d49b147ac19000079f6817

😎 Browse the preview: https://deploy-preview-123--pensive-meitner-faaeee.netlify.app

Copy link
Contributor

@ebeneliason ebeneliason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ebeneliason
Copy link
Contributor

ebeneliason commented Jan 4, 2022

Oh, one thing to look out for with any Docusaurus version bump is whether any changes were made to components that we've swizzled (TOCItem, Toggle). I'm not sure if there's any mechanism in place to automatically detect this and suggest changes. I'm also not sure if there's any best practice way to apply our changes to a "re-swizzled" component. Thoughts?

@oredavids
Copy link
Contributor Author

@ebeneliason

I checked the release notes for TOCItem originally and there haven't been any updates to that component in any new release after our current version.

I have now seen an update for the Toggle component which is swizzled in your PR #120. We could wait till this PR is merged to re-swizzle that component because it was simplified in v2-beta-10- it is categorized as a polish so it is not a breaking change so waiting & re-doing the PR is not necessary.

Generally, I could not find any mechanism in place to automatically detect/suggest changes to swizzled components and that is somewhat understandable given that Docusaurus does not recommend sizzling while they are still in the beta phase. We will have to keep checking release notes before any future upgrades.

@ebeneliason
Copy link
Contributor

I have now seen an update for the Toggle component which is swizzled in your PR #120. We could wait till this PR is merged to re-swizzle that component…

That sounds like a plan. Feel free to merge this when ready!

@oredavids oredavids merged commit 23eb462 into master Jan 4, 2022
@oredavids oredavids deleted the apt-1554-docs-google-search branch January 4, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants