Skip to content

Conversation

ebeneliason
Copy link
Contributor

This tweaks copy and layout on the homepage to provide a better
visual hierarchy. It also introduces some changes to the Card
component and styles to support the new look in cleaner fashion.

This tweaks copy and layout on the homepage to provide a better
visual hierarchy. It also introduces some changes to the Card
component and styles to support the new look in cleaner fashion.
@netlify
Copy link

netlify bot commented Jan 6, 2022

✔️ Deploy Preview for pensive-meitner-faaeee ready!

🔨 Explore the source changes: 7452ed8

🔍 Inspect the deploy log: https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/61d85a12a173ed0007383137

😎 Browse the preview: https://deploy-preview-127--pensive-meitner-faaeee.netlify.app

@josh-padnick
Copy link
Contributor

I was just browsing this and this looks awesome! Some additional small feedback:

  • What is Gruntwork? Shorten text to "
    Learn how Gruntwork products can help you deploy a world class infrastructure.
    "
  • I love the RefArch vs "Deploy a Service" breakdown. The icons are great, too!
  • Setup your accounts. Should this be "Setup Your AWS Multi-Account Structure"?
  • Create a CI/CD Pipeline. Adjust to "Create a CI/CD Pipeline for Infra." Might be too long, but we want to clarify it's for infra.
  • Change "deploy a k8s cluster" to "Deploy Kubernetes using EKS"?
  • Finally, perhaps there's some kind of common icon we can use to signify a "use case"? Maybe a single cube, or a document icon or something else.

These are all off-the-cuff ideas. You should make the final call on everything here.


return (
<section
<div
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more semantically correct right? section refers more to a "section" in a document rather than this..being a grid, which is more of a container. Am I understanding this properly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same thought initially, but in practice I noticed a couple of related things that changed my mind.

  1. In some cases the Grid belongs logically grouped with some other content, e.g. a header, or supplemental text. In those cases, the semantic "section" is all of that content taken together, not just the grid.
  2. In some cases, the component using the grid already had a higher level notion of section, which resulted in nested sections. Nested sections aren't prohibited, but semantically it was again incorrect, since the section is meant to map to a section of the page that would be shown in a document outline.

href="/docs/guides/reference-architecture/overview/overview"
icon="/img/icons/refarch.svg"
>
Bootstrap your infrastructure in about a day by letting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This feels more like a marketing blurb and less like verbiage that will help customers find docs for interacting with their Ref Arch.

I could see something like: "Got a Ref Arch deployed? Learn all about it" <-- not this exact text...but the gist should be "if you got the ref arch, this is where you can learn about how to absorb it into your org"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's fair. Updated!

eak12913
eak12913 previously approved these changes Jan 7, 2022
Copy link
Contributor

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a minor nit - but it's not a blocker. So I'm approving this and can re-stamp if we do end up making changes.

Copy link
Contributor

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eak12913 eak12913 merged commit 90234be into master Jan 7, 2022
@eak12913 eak12913 deleted the apt-1631-homepage-update branch January 7, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants