-
Notifications
You must be signed in to change notification settings - Fork 43
[APT-1591] Run docs-sourcer on file deletes #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR switches out `nodemon` for `onchange`. Unfortunately `nodemon` did not have a simple way of triggering on deletes. `onchange` supports running the requisite commands on deletes in addition to file additions and changes.
|
✔️ Deploy Preview for pensive-meitner-faaeee ready! 🔨 Explore the source changes: dcaff43 🔍 Inspect the deploy log: https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/61e1b6eaa15a6d00096b2cf4 😎 Browse the preview: https://deploy-preview-134--pensive-meitner-faaeee.netlify.app |
Co-authored-by: Eben Eliason <eben.eliason@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once nodemon package is removed.
…un once initially.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
This PR switches out
nodemonforonchange. Unfortunatelynodemondid not have a simple way of triggering on deletes.onchangesupports running the requisite commands on deletes in addition to file additions and changes.