[APT-1652] Fix alignment/zoom for avatars on courses page #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebeneliason
requested review from
eak12913,
oredavids and
pete0emerson
as code owners
|
✔️ Deploy Preview for pensive-meitner-faaeee ready! 🔨 Explore the source changes: 885b807 🔍 Inspect the deploy log: https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/61e73705cccf1f0008b7ee68 😎 Browse the preview: https://deploy-preview-139--pensive-meitner-faaeee.netlify.app |
eak12913
reviewed
Jan 19, 2022
| } | ||
| : undefined, | ||
| zoomSelector: ".markdown img", | ||
| zoomSelector: ".markdown :not(em) > img:not(.no-zoom)", |
There was a problem hiding this comment.
Am emphasis (<em>) tag. This selector is a little tricky, as it is designed to handle two separate cases in which we don't want zoom.
- The first is the
:not(em)bit, which is a standard approach to preventing image zoom documented in some of the zoom plugins. It enables one to wrap the Markdown image syntax in underscores (_) to trigger an emphasis (<em>) wrapper, which thus makes this selector fail. - The second adds an explicit
.no-zoomclass that we can add to images where we aren't specifying them in Markdown. I could have just added an<em>wrapper in React, but the classname seemed cleaner in that context.
The selector here essentially says, select an image for which neither of the above are true. That is, if it's wrapped in emphasis or has the .no-zoom class, the selector won't apply.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.