Skip to content

Conversation

jalessio
Copy link
Contributor

I think the docker login command should be targeting us-west-2 since that is the region where the ECR repo is located.

I think the `docker login` command should be targeting `us-west-2` since that is the region where the ECR repo is located.
@netlify
Copy link

netlify bot commented Jan 30, 2022

✔️ Deploy Preview for pensive-meitner-faaeee ready!

🔨 Explore the source changes: f4a0970

🔍 Inspect the deploy log: https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/61f6be9b5a70f200081df185

😎 Browse the preview: https://deploy-preview-159--pensive-meitner-faaeee.netlify.app

@rhoboat
Copy link
Contributor

rhoboat commented Jan 30, 2022

I've got a PR to change this upstream. We'd have to re-pull the generated docs there (or from the for-production examples in the service-catalog repo). The reviewers on this repo will know best how to update these docs based on that generation process. (There might be other changes to the docs that we've made upstream.)

eak12913 added a commit that referenced this pull request Jan 31, 2022
This PR addresses one small typo in `forking.md` and addresses @jalessio's suggestions in #159
@eak12913 eak12913 mentioned this pull request Jan 31, 2022
@eak12913
Copy link
Contributor

@jalessio - Thanks for the submission. I'm going to close this PR in favor of #162 as the file you've changed (though a logical thing to change) is actually a generated file. We haven't done a great job yet with exposing an easy way to submit a change that gets properly built. Thank you for the contribution anyway!

@eak12913 eak12913 closed this Jan 31, 2022
@jalessio jalessio deleted the patch-1 branch January 31, 2022 18:25
ebeneliason pushed a commit that referenced this pull request Feb 2, 2022
This PR addresses one small typo in `forking.md` and addresses @jalessio's suggestions in #159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants