-
Couldn't load subscription status.
- Fork 43
add HCL promotion to whats new #2822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughDocumentation update to the Terragrunt upgrade guide: added sections detailing support for newer Terragrunt versions through 1.0 and promoting HCL as the default configuration format while deprecating YML. Removed outdated version compatibility information. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes The changes are limited to a single documentation file with straightforward content additions and removals. Review effort focuses on validating the accuracy of version information and deprecation messaging. Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/2.0/docs/pipelines/previous-versions/upgrading-github-v3-to-v4.md (1)
8-9: Minor clarity: Standardize version range wording between heading and body.Line 8 uses "through to 1.0" but line 9 says "through to 1.0+". For consistency and clarity, align these. Consider using standard phrasing like "through 1.0+" or "1.0 and later" in both places.
-### Support for newer Terragrunt Versions (through to 1.0) -Pipelines previously had maximum Terragrunt version of 0.84. This version of Pipelines removes this restriction and will support all Terragrunt versions from `0.86.3` through to 1.0+. +### Support for newer Terragrunt Versions (through 1.0 and later) +Pipelines previously had maximum Terragrunt version of 0.84. This version of Pipelines removes this restriction and will support all Terragrunt versions from `0.86.3` through 1.0 and later.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/2.0/docs/pipelines/previous-versions/upgrading-github-v3-to-v4.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Pull Request has non-contributor approval
- GitHub Check: Pull Request has non-contributor approval
- GitHub Check: Validate generated content
- GitHub Check: validate_build
🔇 Additional comments (1)
docs/2.0/docs/pipelines/previous-versions/upgrading-github-v3-to-v4.md (1)
11-12: Content looks good and integrates well with the migration guide.This section clearly communicates the HCL promotion and YML deprecation, which aligns nicely with the "Replace YML Config with HCL Config" section (line 104+). The messaging is consistent and sets up the migration path well for readers.
If you haven't already, ensure the "full feature parity" claim is documented or linked elsewhere in your docs so readers can verify this is comprehensive. A link to the API reference or feature comparison would strengthen this.
Summary by CodeRabbit