-
Notifications
You must be signed in to change notification settings - Fork 42
Update Gruntwork Releases as of 2025-11-30 #2861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughDocumentation updates for the Gruntwork stay-up-to-date guide, including new 2025-11 release announcement card, corresponding monthly release page with updates across twelve repositories, reordered 2024-04 release entries, expanded 2025-10 release notes, and updated content hashes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
docs/guides/stay-up-to-date/index.md(2 hunks)docs/guides/stay-up-to-date/releases/2024-04/index.md(2 hunks)docs/guides/stay-up-to-date/releases/2025-10/index.md(4 hunks)docs/guides/stay-up-to-date/releases/2025-11/index.md(1 hunks)docs/guides/stay-up-to-date/releases/index.md(2 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/guides/stay-up-to-date/releases/2025-11/index.md
[uncategorized] ~76-~76: The official name of this software platform is spelled with a capital “H”.
Context: ...99
- DEV-1201 Fix retry failed jobs in github flaking by @Resonance1584 in https://gi...
(GITHUB)
[grammar] ~215-~215: Use a hyphen to join words.
Context: ...r than the deploy branch
- Remove ahead of main check from preflight when workfl...
(QB_NEW_EN_HYPHEN)
[grammar] ~215-~215: Use a hyphen to join words.
Context: ...han the deploy branch
- Remove ahead of main check from preflight when workflow ...
(QB_NEW_EN_HYPHEN)
🪛 markdownlint-cli2 (0.18.1)
docs/guides/stay-up-to-date/releases/2025-11/index.md
38-38: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
38-38: Bare URL used
(MD034, no-bare-urls)
41-41: Bare URL used
(MD034, no-bare-urls)
58-58: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
58-58: Bare URL used
(MD034, no-bare-urls)
61-61: Bare URL used
(MD034, no-bare-urls)
75-75: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
75-75: Bare URL used
(MD034, no-bare-urls)
76-76: Inconsistent indentation for list items at the same level
Expected: 2; Actual: 0
(MD005, list-indent)
76-76: Bare URL used
(MD034, no-bare-urls)
79-79: Bare URL used
(MD034, no-bare-urls)
100-100: Bare URL used
(MD034, no-bare-urls)
103-103: Bare URL used
(MD034, no-bare-urls)
117-117: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
117-117: Bare URL used
(MD034, no-bare-urls)
118-118: Inconsistent indentation for list items at the same level
Expected: 2; Actual: 0
(MD005, list-indent)
118-118: Bare URL used
(MD034, no-bare-urls)
121-121: Bare URL used
(MD034, no-bare-urls)
142-142: Bare URL used
(MD034, no-bare-urls)
145-145: Bare URL used
(MD034, no-bare-urls)
162-162: Bare URL used
(MD034, no-bare-urls)
176-176: Bare URL used
(MD034, no-bare-urls)
179-179: Bare URL used
(MD034, no-bare-urls)
198-198: Bare URL used
(MD034, no-bare-urls)
200-200: Bare URL used
(MD034, no-bare-urls)
218-218: Bare URL used
(MD034, no-bare-urls)
235-235: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
235-235: Bare URL used
(MD034, no-bare-urls)
236-236: Inconsistent indentation for list items at the same level
Expected: 2; Actual: 0
(MD005, list-indent)
236-236: Bare URL used
(MD034, no-bare-urls)
239-239: Bare URL used
(MD034, no-bare-urls)
252-252: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
255-255: Bare URL used
(MD034, no-bare-urls)
268-268: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
268-268: Bare URL used
(MD034, no-bare-urls)
271-271: Bare URL used
(MD034, no-bare-urls)
288-288: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
288-288: Bare URL used
(MD034, no-bare-urls)
290-290: Inconsistent indentation for list items at the same level
Expected: 2; Actual: 0
(MD005, list-indent)
290-290: Bare URL used
(MD034, no-bare-urls)
292-292: Bare URL used
(MD034, no-bare-urls)
305-305: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
305-305: Bare URL used
(MD034, no-bare-urls)
308-308: Bare URL used
(MD034, no-bare-urls)
349-349: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
349-349: Bare URL used
(MD034, no-bare-urls)
350-350: Inconsistent indentation for list items at the same level
Expected: 2; Actual: 0
(MD005, list-indent)
350-350: Bare URL used
(MD034, no-bare-urls)
351-351: Inconsistent indentation for list items at the same level
Expected: 2; Actual: 0
(MD005, list-indent)
351-351: Bare URL used
(MD034, no-bare-urls)
352-352: Inconsistent indentation for list items at the same level
Expected: 2; Actual: 0
(MD005, list-indent)
352-352: Bare URL used
(MD034, no-bare-urls)
355-355: Bare URL used
(MD034, no-bare-urls)
393-393: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
393-393: Bare URL used
(MD034, no-bare-urls)
394-394: Inconsistent indentation for list items at the same level
Expected: 2; Actual: 0
(MD005, list-indent)
394-394: Bare URL used
(MD034, no-bare-urls)
395-395: Inconsistent indentation for list items at the same level
Expected: 2; Actual: 0
(MD005, list-indent)
395-395: Bare URL used
(MD034, no-bare-urls)
396-396: Inconsistent indentation for list items at the same level
Expected: 2; Actual: 0
(MD005, list-indent)
396-396: Bare URL used
(MD034, no-bare-urls)
397-397: Inconsistent indentation for list items at the same level
Expected: 2; Actual: 0
(MD005, list-indent)
397-397: Bare URL used
(MD034, no-bare-urls)
399-399: Inconsistent indentation for list items at the same level
Expected: 2; Actual: 0
(MD005, list-indent)
399-399: Bare URL used
(MD034, no-bare-urls)
401-401: Bare URL used
(MD034, no-bare-urls)
docs/guides/stay-up-to-date/releases/2024-04/index.md
588-588: Bare URL used
(MD034, no-bare-urls)
docs/guides/stay-up-to-date/releases/2025-10/index.md
665-665: Link text should be descriptive
(MD059, descriptive-link-text)
678-678: Link text should be descriptive
(MD059, descriptive-link-text)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Validate generated content
- GitHub Check: Pull Request has non-contributor approval
- GitHub Check: Validate generated content
- GitHub Check: Pull Request has non-contributor approval
- GitHub Check: validate_build
🔇 Additional comments (5)
docs/guides/stay-up-to-date/releases/2024-04/index.md (1)
554-592: Reordering and metadata updates look correct.The swap of v0.21.15 and v0.21.14 with updated publication dates and module information follows the expected chronological ordering (most recent first). The hash update on line 1633 is appropriate for the content changes.
docs/guides/stay-up-to-date/releases/2025-10/index.md (1)
24-24: Structural changes look good!The additions of terraform-aws-vpc to the TOC, the new v0.140.0 release block, and the expanded terraform-aws-vpc section all follow established patterns and integrate cleanly. The formatting and spacing are consistent with the rest of the document.
Also applies to: 637-652, 866-884
docs/guides/stay-up-to-date/releases/index.md (1)
14-14: Perfect!The new 2025-11 release card is correctly positioned at the top of the list, follows the established naming and href patterns, and maintains chronological ordering. The DOCS-SOURCER hash has been updated appropriately.
docs/guides/stay-up-to-date/index.md (1)
20-20: Clean update to the landing page!The new 2025-11 card is correctly positioned and follows the naming/href conventions. By rotating out the oldest entry (2024-08) while adding the newest (2025-11), you've kept the landing page focused on the most recent and relevant releases—good UX thinking.
docs/guides/stay-up-to-date/releases/2025-11/index.md (1)
1-490: Excellent! New release page is well-structured.The new 2025-11 release page follows the established template perfectly. The breadcrumb navigation, intro text, repository TOC, and release entry formatting all align with the 2025-10 page. The twelve repositories are documented with consistent formatting.
The linting warnings flagged by static analysis (unordered list indentation, bare URLs, capitalization) are all present in auto-generated changelog content sourced from upstream GitHub releases. These are acceptable for this type of documentation—the team can address formatting consistency across the codebase independently if desired (e.g., via a post-processing step or formatter configuration).
| ### [v0.21.14](https://github.com/gruntwork-io/terraform-aws-asg/releases/tag/v0.21.14) | ||
|
|
||
| <p style={{marginTop: "-20px", marginBottom: "10px"}}> | ||
| <small>Published: 4/5/2024 | Modules affected: asg-rolling-deploy | <a href="https://github.com/gruntwork-io/terraform-aws-asg/releases/tag/v0.21.15">Release notes</a></small> | ||
| <small>Published: 4/2/2024 | Modules affected: server-group | <a href="https://github.com/gruntwork-io/terraform-aws-asg/releases/tag/v0.21.14">Release notes</a></small> | ||
| </p> | ||
|
|
||
| <div style={{"overflow":"hidden","textOverflow":"ellipsis","display":"-webkit-box","WebkitLineClamp":10,"lineClamp":10,"WebkitBoxOrient":"vertical"}}> | ||
|
|
||
|
|
||
| - `server-group` | ||
|
|
||
| - asg-rolling-deploy: support autoscaling lifecycle hook | ||
|
|
||
| - Expose `max_session_duration` for server-group vended role | ||
|
|
||
|
|
||
| - https://github.com/gruntwork-io/terraform-aws-asg/pull/211 | ||
|
|
||
|
|
||
|
|
||
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format the PR reference as a markdown link.
Line 588 contains a bare URL that should be properly formatted as a markdown link for consistency with the documentation style and to satisfy linting requirements.
Apply this diff to fix the formatting:
- `server-group`
- Expose `max_session_duration` for server-group vended role
- - https://github.com/gruntwork-io/terraform-aws-asg/pull/211
+ - [PR #211](https://github.com/gruntwork-io/terraform-aws-asg/pull/211)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ### [v0.21.14](https://github.com/gruntwork-io/terraform-aws-asg/releases/tag/v0.21.14) | |
| <p style={{marginTop: "-20px", marginBottom: "10px"}}> | |
| <small>Published: 4/5/2024 | Modules affected: asg-rolling-deploy | <a href="https://github.com/gruntwork-io/terraform-aws-asg/releases/tag/v0.21.15">Release notes</a></small> | |
| <small>Published: 4/2/2024 | Modules affected: server-group | <a href="https://github.com/gruntwork-io/terraform-aws-asg/releases/tag/v0.21.14">Release notes</a></small> | |
| </p> | |
| <div style={{"overflow":"hidden","textOverflow":"ellipsis","display":"-webkit-box","WebkitLineClamp":10,"lineClamp":10,"WebkitBoxOrient":"vertical"}}> | |
| - `server-group` | |
| - asg-rolling-deploy: support autoscaling lifecycle hook | |
| - Expose `max_session_duration` for server-group vended role | |
| - https://github.com/gruntwork-io/terraform-aws-asg/pull/211 | |
| </div> | |
| ### [v0.21.14](https://github.com/gruntwork-io/terraform-aws-asg/releases/tag/v0.21.14) | |
| <p style={{marginTop: "-20px", marginBottom: "10px"}}> | |
| <small>Published: 4/2/2024 | Modules affected: server-group | <a href="https://github.com/gruntwork-io/terraform-aws-asg/releases/tag/v0.21.14">Release notes</a></small> | |
| </p> | |
| <div style={{"overflow":"hidden","textOverflow":"ellipsis","display":"-webkit-box","WebkitLineClamp":10,"lineClamp":10,"WebkitBoxOrient":"vertical"}}> | |
| - `server-group` | |
| - Expose `max_session_duration` for server-group vended role | |
| - [PR #211](https://github.com/gruntwork-io/terraform-aws-asg/pull/211) | |
| </div> |
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
588-588: Bare URL used
(MD034, no-bare-urls)
🤖 Prompt for AI Agents
In docs/guides/stay-up-to-date/releases/2024-04/index.md around lines 573 to
592, there is a bare URL on line 588 for the PR reference; replace that bare URL
with a markdown link to match the docs style (for example change the line to a
list entry like "-
[#211](https://github.com/gruntwork-io/terraform-aws-asg/pull/211)") and ensure
it remains part of the bullet list formatting.
|
|
||
|
|
||
| - Add Support for AL2023 EKS Worker AMI's | ||
| Add Support for AL2023 EKS Worker AMI's. New configurations have been added to `autoscaling_group_configurations` and `managed_node_group_configurations` to support both AL2 and AL2023 AMI Types. Users on an AMI Type other than AL2 will need to proactively set the corresponding `autoscaling_group_configurations.asg_ami_type` and/or managed_node_group_configurations.ami_type` to ensure the correct user data script is used during initialization of the worker node(s). See [here](https://github.com/gruntwork-io/terraform-aws-service-catalog/blob/v0.130.7/modules/services/eks-workers/user_data.tf#L49-L57) for current supported AMI Type configurations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve link text for accessibility and SEO.
The "here" links at these lines should use more descriptive anchor text per MD059 standards. Link text like [here] provides no context to users or search engines about what they'll find when clicking.
Consider rewording to something like:
- See [here](https://github.com/gruntwork-io/terraform-aws-service-catalog/blob/v0.130.7/modules/services/eks-workers/user_data.tf#L49-L57) for current supported AMI Type configurations.
+ See the [supported AMI Type configurations](https://github.com/gruntwork-io/terraform-aws-service-catalog/blob/v0.130.7/modules/services/eks-workers/user_data.tf#L49-L57) for details.
- An example would be `AL2023_x86_64_STANDARD`. See [here](https://github.com/gruntwork-io/terraform-aws-service-catalog/blob/v0.130.7/modules/services/eks-workers/user_data.tf#L49-L57) for current supported AMI Type configurations.
+ An example would be `AL2023_x86_64_STANDARD`. Refer to the [supported AMI Type configurations](https://github.com/gruntwork-io/terraform-aws-service-catalog/blob/v0.130.7/modules/services/eks-workers/user_data.tf#L49-L57) for the complete list.Also applies to: 678-678
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
665-665: Link text should be descriptive
(MD059, descriptive-link-text)
🤖 Prompt for AI Agents
In docs/guides/stay-up-to-date/releases/2025-10/index.md around lines 665 and
678, the link text uses non-descriptive "[here]" anchors; replace each "[here]"
with descriptive anchor text such as "user_data.tf AL2/AL2023 AMI Type
configurations on GitHub" (or similar concise, descriptive phrasing) and keep
the existing URL so the link reads like: See the user_data.tf AL2/AL2023 AMI
Type configurations on GitHub for current supported AMI Type configurations.;
ensure both occurrences are updated to the same descriptive text to satisfy
MD059.
Update Gruntwork releases as of 2025-11-30
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.