Upgrade to docusaurus v2.2.0 #605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oredavids
requested review from
eak12913,
ebeneliason and
pete0emerson
as code owners
✅ Deploy Preview for pensive-meitner-faaeee ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
oredavids
changed the title
eak12913
reviewed
Jan 19, 2023
eak12913
reviewed
Jan 19, 2023
eak12913
reviewed
Jan 19, 2023
There was a problem hiding this comment.
Docusaurus now requires node v16.14.0; do we need to make infra changes for stage & prod?
I don't think we will need to make changes beyond what you did in CircleCI config. There's no node server running in prod. It's just generating a bunch of HTML files that are being uploaded into an S3 bucket.
Ah, yes! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanity Check