-
Notifications
You must be signed in to change notification settings - Fork 43
Update releases through Jan 31, 2023 #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for pensive-meitner-faaeee ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait - there's an issue here with document hashes. Looking into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
|
||
|
|
||
| - Add patch for tflint hook setup for CIS RefArch users | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: There are a couple of empty lines surrounding the modules affected.
| <Card title="Update to 2022-02" href="/guides/stay-up-to-date/releases/2022-02" /> | ||
| <Card title="Update to 2022-01" href="/guides/stay-up-to-date/releases/2022-01" /> | ||
| <Card title="Update to 2021-12" href="/guides/stay-up-to-date/releases/2021-12" /> | ||
| <Card title="Update to 2021-11" href="/guides/stay-up-to-date/releases/2021-11" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened here? Are we losing some of these releases?
Ah, you know, that's prob me. I meant to run this on Jan 31, but was busy, so I ran it on Feb 1. That included a Feb releases page, but nearly empty, since Feb just started. So I manually deleted it from the output, as otherwise, several weeks from now, it'll look like we did nothing in February at all. But yea, that manual clean up prob doesn't work with hashes. |
|
I should prob add a way to optionally set the "up to" date in the |
|
OK, I updated the docs-sourcer PR to allow me to set a "all releases before date xxx" param, so now this PR has releases just through Jan 31, 2023. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jim!
No description provided.