Skip to content

Conversation

@brikis98
Copy link
Member

@brikis98 brikis98 commented Feb 1, 2023

No description provided.

@netlify
Copy link

netlify bot commented Feb 1, 2023

Deploy Preview for pensive-meitner-faaeee ready!

Name Link
🔨 Latest commit 4294d6c
🔍 Latest deploy log https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/63dbe8cce77c9b000820d51e
😎 Deploy Preview https://deploy-preview-621--pensive-meitner-faaeee.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait - there's an issue here with document hashes. Looking into it.

oredavids
oredavids previously approved these changes Feb 1, 2023
Copy link
Contributor

@oredavids oredavids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment on lines +122 to +130


- Add patch for tflint hook setup for CIS RefArch users






Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: There are a couple of empty lines surrounding the modules affected.

<Card title="Update to 2022-02" href="/guides/stay-up-to-date/releases/2022-02" />
<Card title="Update to 2022-01" href="/guides/stay-up-to-date/releases/2022-01" />
<Card title="Update to 2021-12" href="/guides/stay-up-to-date/releases/2021-12" />
<Card title="Update to 2021-11" href="/guides/stay-up-to-date/releases/2021-11" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened here? Are we losing some of these releases?

@brikis98
Copy link
Member Author

brikis98 commented Feb 2, 2023

Wait - there's an issue here with document hashes. Looking into it.

Ah, you know, that's prob me. I meant to run this on Jan 31, but was busy, so I ran it on Feb 1. That included a Feb releases page, but nearly empty, since Feb just started. So I manually deleted it from the output, as otherwise, several weeks from now, it'll look like we did nothing in February at all. But yea, that manual clean up prob doesn't work with hashes.

@brikis98
Copy link
Member Author

brikis98 commented Feb 2, 2023

I should prob add a way to optionally set the "up to" date in the docs-sourcer rather than just doing "up to today."

@brikis98
Copy link
Member Author

brikis98 commented Feb 2, 2023

OK, I updated the docs-sourcer PR to allow me to set a "all releases before date xxx" param, so now this PR has releases just through Jan 31, 2023.

Copy link
Contributor

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jim!

@eak12913 eak12913 merged commit 339c384 into master Feb 8, 2023
@eak12913 eak12913 deleted the enhancement/update-releases-feb-2023 branch February 8, 2023 15:24
@brikis98 brikis98 restored the enhancement/update-releases-feb-2023 branch March 3, 2023 19:18
@oredavids oredavids deleted the enhancement/update-releases-feb-2023 branch May 17, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants