CIS v1.5 Upgrade - text fixes #668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marinalimeira
requested review from
eak12913,
ebeneliason,
oredavids and
pete0emerson
as code owners
✅ Deploy Preview for pensive-meitner-faaeee ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
brikis98
approved these changes
Mar 6, 2023
Member
brikis98
left a comment
brikis98
left a comment
There was a problem hiding this comment.
These are nice improvements 👍
| # order as the AWS CLI: | ||
| # 1. The `AWS_DEFAULT_REGION` or `AWS_REGION` environment variable | ||
| # 2. The region specified in the active profile (`AWS_PROFILE` or default) | ||
| regions = ["*"] # <- Update this line |
Member
There was a problem hiding this comment.
Update this line to what? Isn't this the right value to connect to all regions?
Contributor
Author
There was a problem hiding this comment.
This line is initially commented
Contributor
Author
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While recording the demo, I noticed somethings were incomplete: