Update RefArch Setup Guide - CORE-491 #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsci
requested review from
eak12913,
ebeneliason,
oredavids and
pete0emerson
as code owners
✅ Deploy Preview for pensive-meitner-faaeee ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
arsci
changed the title
_docs-sources/guides/reference-architecture/configuration-guide/index.md
Outdated
Show resolved
Hide resolved
_docs-sources/guides/reference-architecture/configuration-guide/index.md
Outdated
Show resolved
Hide resolved
_docs-sources/guides/reference-architecture/configuration-guide/index.md
Outdated
Show resolved
Hide resolved
_docs-sources/guides/reference-architecture/configuration-guide/index.md
Outdated
Show resolved
Hide resolved
_docs-sources/guides/reference-architecture/configuration-guide/index.md
Outdated
Show resolved
Hide resolved
I think I got them all. It's much more consistent having it defined first rather than switching back and forth, great suggestion. I pulled similar comments from the other PR into this one as well to make both guides match as closely as possible. |
_docs-sources/guides/reference-architecture/configuration-guide/index.md
Outdated
Show resolved
Hide resolved
_docs-sources/guides/reference-architecture/configuration-guide/index.md
Outdated
Show resolved
Hide resolved
| Reference Architecture deployments. | ||
|
|
||
| ## Create and configure AWS Accounts | ||
| First we will create a GitHub Personal Access Token: |
There was a problem hiding this comment.
Should we use PAT here or fully spell out Personal Access Token? WDYT?
There was a problem hiding this comment.
This one felt a little more appropriate to leave full spelled out
_docs-sources/guides/reference-architecture/configuration-guide/index.md
Outdated
Show resolved
Hide resolved
_docs-sources/guides/reference-architecture/configuration-guide/index.md
Outdated
Show resolved
Hide resolved
|
|
||
| - Then create _another_ secret in AWS Secrets Manager in the _shared_ account containing this PAT. **Note the ARN, as in the GitHub step above**. | ||
| ```bash | ||
| export GITHUB_OAUTH_TOKEN=<YOUR GITHUB PERSONAL ACCESS TOKEN> |
There was a problem hiding this comment.
Suggested change
| export GITHUB_OAUTH_TOKEN=<YOUR GITHUB PERSONAL ACCESS TOKEN> | |
| export GITHUB_OAUTH_TOKEN=<YOUR GITHUB PAT> |
I waffled back on forth on if it was additive to the reader to continue to use PAT even in things like this. WDYT?
There was a problem hiding this comment.
I think writing it out here makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating RefArch Setup Guide to better reflect the guide used in the infrastructure-live repo template README, with primary changes around the Machine User section of the guide.
See also: infrastructure-live template PR#75