-
Couldn't load subscription status.
- Fork 43
Add static JSONS for module's releases #732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for pensive-meitner-faaeee ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -0,0 +1,1655 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can compare this with the changelog.md https://github.com/gruntwork-io/terraform-aws-service-catalog/blob/master/modules/mgmt/openvpn-server/CHANGELOG.md, and have the same result!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file seems to have snuck through. I thought I saw an entry in the ignore list for it - but still see it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed - 6d5ff3e. There was a conditional missing.
static/patcher-changelogs/terraform-aws-static-assets/_docs.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Candidate for the ignore file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked about this in the docs-sourcer PR - but I think we should consider shell scripts in the ignore list right?
|
@eak12913 can I leave the scripts jsons for now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with the extra scripts as we anticipate that Patcher will be switching to using a dedicated API in the future and we will be able to either iterate or deprecate the changes from this PR.
Description
[Notion] Changelogs in the Docs website
[Jira] PATCHER-95
This PR contains the generated code from https://github.com/gruntwork-io/docs-sourcer/pull/121.
For each module in each Terraform repo, the JSON represents whenever the module had some change in that release.