Skip to content

Conversation

@marinalimeira
Copy link
Contributor

@marinalimeira marinalimeira commented Apr 18, 2023

Description

[Notion] Changelogs in the Docs website
[Jira] PATCHER-95

This PR contains the generated code from https://github.com/gruntwork-io/docs-sourcer/pull/121.

For each module in each Terraform repo, the JSON represents whenever the module had some change in that release.

@netlify
Copy link

netlify bot commented Apr 18, 2023

Deploy Preview for pensive-meitner-faaeee ready!

Name Link
🔨 Latest commit db323c3
🔍 Latest deploy log https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/645ccede2528be00083a7bcb
😎 Deploy Preview https://deploy-preview-732--pensive-meitner-faaeee.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@@ -0,0 +1,1655 @@
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file seems to have snuck through. I thought I saw an entry in the ignore list for it - but still see it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed - 6d5ff3e. There was a conditional missing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Candidate for the ignore file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked about this in the docs-sourcer PR - but I think we should consider shell scripts in the ignore list right?

@marinalimeira
Copy link
Contributor Author

marinalimeira commented May 11, 2023

@eak12913 can I leave the scripts jsons for now?

Copy link
Contributor

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the extra scripts as we anticipate that Patcher will be switching to using a dedicated API in the future and we will be able to either iterate or deprecate the changes from this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants