Skip to content

Conversation

@marinalimeira
Copy link
Contributor

@marinalimeira marinalimeira commented Apr 28, 2023

@netlify
Copy link

netlify bot commented Apr 28, 2023

Deploy Preview for pensive-meitner-faaeee ready!

Name Link
🔨 Latest commit c21e1f1
🔍 Latest deploy log https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/6450dc4a7cdc4900081d0c95
😎 Deploy Preview https://deploy-preview-763--pensive-meitner-faaeee.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.


Patcher runs in single binary called `patcher`. Make sure it's available within your `PATH`.

1. After downloading Patcher, unzip the package (only MacOS releases are zipped). Patcher runs in a single binary.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patcher runs in a single binary
Do we need to add that context? I think it may be more clear to say something like:

Suggestion:
"After downloading Patcher, move it to your desired destination directory. If you're using MacOS, you will have to unzip the package. For other operating systems, the artifact you download is the executable itself."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that sounds good! Thanks

```
mv patcher_linux_amd64 patcher
```
3. Move `patcher` to a location available in your `PATH`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want the customer to do this? Or do we want them instead to install by placing the executable into some /opt/patcher location and then having some kind of symlink between /usr/local/bin and the patcher executable in /opt/patcher?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either would work. What would be the difference of moving to /opt/patcher?


## Before Running Patcher

To fetch information from GitHub, Patcher requires a GitHub Personal Access Token, with the `repo` scope. Set the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Personal Access Token

Consider linking this to GitHub's docs about PATs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patcher should be run in a local Terraform or Terragrunt Git repo. It will analyze _all_ modules that belong to the current folder
including its children. Patcher supports `source` values only from GitHub.

In an `infrastructure-live` repository, we recommend running Patcher inside each environment folder, e.g. `infrastructure-live/dev`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here we may want some added context about our Reference Architecture.

Something like:
"If you purchased and deployed our Reference Architecture and have your deployment organized in an infrastructure-live repository......"


### Patcher Report

In `0.2.x`, the only available command is `patcher report`. This is a read-only version of Patcher that shows the changelog per module and its usages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In `0.2.x`, the only available command is `patcher report`. This is a read-only version of Patcher that shows the changelog per module and its usages.
In `v0.2.x`, the only available command is `patcher report`. This is a read-only version of Patcher that shows the changelog per module and its usages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may also be helpful to say something like:

"After running patcher report you will end up in the 'Modules View'".

This context will be helpful in your next 2 sections where you refer to other command that are available from the 'Modules View'


![Patcher Changelogs screenshot](/img/guides/stay-up-to-date/patcher/patcher-changelogs.png)

2.1. Some modules do not have a CHANGELOGS.md file.In this case, press `o` to open the releases page for that repository:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be indented? Additionally, consider using an info call-out here rather than "2.1":

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be indented?

Yes, I don't know how to fix this given the items below.


### CIS AWS v1.5 Upgrade

In `v0.1.x`, the only command available is `patcher upgrade cis`. This will upgrade your service catalogs to the latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did patcher upgrade cis get removed in v0.2.x? If it didn't, then your messaging above will need to be adjusted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it was!

```
3. Move `patcher` to a location available in your `PATH`.
```bash
echo $PATH
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For examples where the second command is dependent on the output of the first, I find it useful to show the output of the first command. e.g.,

Suggested change
echo $PATH
echo $PATH
> /usr/local/bin
mv patcher /usr/local/bin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add an example of full path, hopefully this avoids confusion.

@techpink techpink self-requested a review May 2, 2023 11:35
Copy link
Contributor

@techpink techpink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp approval based on a conversation with Marina

@marinalimeira
Copy link
Contributor Author

Thanks, Jason! For some context, see this slack thread.

The docs are not in the right place, but given the docs website will have structural changes in the next couple of weeks, we will then move Patcher docs to the appropriate place.

@marinalimeira marinalimeira merged commit db3c74d into master May 2, 2023
@marinalimeira marinalimeira deleted the patcher-docs branch May 2, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants