Skip to content

Conversation

@josh-padnick
Copy link
Contributor

@josh-padnick josh-padnick commented May 31, 2023

This a collection of updates to the Library section.

It includes the following updates:

  • Update intro page to include more concrete concepts
  • Use common casing on sidebar so that all titles start with a capital and then use lowercase letters
  • Use language that I've seen resonate with customers live when explaining modules
  • Include an example of a module

This is ready for review, but not ready for merge. I need to give it one more passover.

@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for pensive-meitner-faaeee ready!

Name Link
🔨 Latest commit b147748
🔍 Latest deploy log https://app.netlify.com/sites/pensive-meitner-faaeee/deploys/647f8de1f5ab010008d830a7
😎 Deploy Preview https://deploy-preview-839--pensive-meitner-faaeee.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@josh-padnick josh-padnick changed the title [WIP] Update Library intro Update Library section May 31, 2023
Copy link
Contributor

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one small comment but otherwise the changes make sense to me. Just let us know when you're ready for a final review.

Co-authored-by: Eugene Kolnick <34349331+eak12913@users.noreply.github.com>
@josh-padnick
Copy link
Contributor Author

@eak12913 Thanks for the review! There are more changes I'd like to make, but I think we're ready to release this for now. I'm not sure how releases work here, so would you mind merging and releasing?

@ebeneliason
Copy link
Contributor

@MoonMoon1919 @eak12913 Could you take a look at this and share thoughts on next steps? If everyone is on board with the changes we should get them in soon so this doesn't rot. There are some conflicts to address given the ongoing work in that section of the docs this sprint already.

@MoonMoon1919
Copy link
Contributor

@ebeneliason I can take a look on Monday

Co-authored-by: Max Moon <moon.maxwell@gmail.com>
@MoonMoon1919
Copy link
Contributor

LGTM. Looks like you'll need to pull in latest from master -> regen the docs to get the conflicts resolved.

MoonMoon1919
MoonMoon1919 previously approved these changes Jun 5, 2023
@josh-padnick
Copy link
Contributor Author

Hm, I wasn't sure which hash to keep, so I kept the one on my branch. Is that the preferred behavior here? If so, this is ready to merge!

image

@oredavids
Copy link
Contributor

oredavids commented Jun 6, 2023

@josh-padnick The hash is a computation based on the exact file content. Except you discarded all changes shown in that particular file's merge conflict; it would be best that you run yarn regenerate:local to compute the hash.

Update: I ran the command and pushed the change. @MoonMoon1919 can you please stamp again?

@josh-padnick
Copy link
Contributor Author

@oredavids @MoonMoon1919 Thanks for the additional review. It sounds like all we need to do is merge this and deploy it. Could one of you run with that?

@MoonMoon1919 MoonMoon1919 merged commit 4fb2214 into master Jun 15, 2023
@MoonMoon1919 MoonMoon1919 deleted the josh-padnick-patch-1 branch June 15, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants