-
Notifications
You must be signed in to change notification settings - Fork 43
Update Library section #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for pensive-meitner-faaeee ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one small comment but otherwise the changes make sense to me. Just let us know when you're ready for a final review.
Co-authored-by: Eugene Kolnick <34349331+eak12913@users.noreply.github.com>
|
@eak12913 Thanks for the review! There are more changes I'd like to make, but I think we're ready to release this for now. I'm not sure how releases work here, so would you mind merging and releasing? |
|
@MoonMoon1919 @eak12913 Could you take a look at this and share thoughts on next steps? If everyone is on board with the changes we should get them in soon so this doesn't rot. There are some conflicts to address given the ongoing work in that section of the docs this sprint already. |
|
@ebeneliason I can take a look on Monday |
Co-authored-by: Max Moon <moon.maxwell@gmail.com>
|
LGTM. Looks like you'll need to pull in latest from master -> regen the docs to get the conflicts resolved. |
|
@josh-padnick The hash is a computation based on the exact file content. Except you discarded all changes shown in that particular file's merge conflict; it would be best that you run Update: I ran the command and pushed the change. @MoonMoon1919 can you please stamp again? |
|
@oredavids @MoonMoon1919 Thanks for the additional review. It sounds like all we need to do is merge this and deploy it. Could one of you run with that? |

This a collection of updates to the Library section.
It includes the following updates:
This is ready for review, but not ready for merge. I need to give it one more passover.